Make FormattedTextAsTree generic, moving special case to FormattedTextAsTreeDefault#27609
Open
CraigMacomber wants to merge 2 commits into
Open
Make FormattedTextAsTree generic, moving special case to FormattedTextAsTreeDefault#27609CraigMacomber wants to merge 2 commits into
CraigMacomber wants to merge 2 commits into
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (1184 lines, 13 files), I've queued these reviewers:
How this works
|
Contributor
Bundle size comparisonBase commit: The PR's CI build failed — fix the build and the comment will update once the next run succeeds. |
brrichards
reviewed
Jun 26, 2026
| * A collection of text related types, schema and utilities for working with text beyond the basic {@link SchemaStatics.string}. | ||
| * @remarks | ||
| * This is a default parameterization of the generic {@link FormattedTextAsTree} with hard-coded assumptions about what kind of embedded content and what kind of formatting is supported. | ||
| * It is unlikely this meeds the needs of most users, but it can serve as an unstable example of how to use the generic {@link FormattedTextAsTree}. |
Contributor
There was a problem hiding this comment.
Suggested change
| * It is unlikely this meeds the needs of most users, but it can serve as an unstable example of how to use the generic {@link FormattedTextAsTree}. | |
| * It is unlikely this meets the needs of most users, but it can serve as an unstable example of how to use the generic {@link FormattedTextAsTree}. |
brrichards
reviewed
Jun 26, 2026
| export interface Statics<TTree> { | ||
| /** | ||
| * Construct a {@link FormattedTextAsTree.(Tree:class)} from a string, where each character (as defined by iterating over the string) becomes a single character in the text node. | ||
| * Construct a a node of `this` schema from a string, where each character (as defined by iterating over the string) becomes a single character in the text node. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Construct a a node of `this` schema from a string, where each character (as defined by iterating over the string) becomes a single character in the text node. | |
| * Construct a node of `this` schema from a string, where each character (as defined by iterating over the string) becomes a single character in the text node. |
brrichards
reviewed
Jun 26, 2026
| * | ||
| * @see {@link FormattedTextAsTree.Statics.fromString} for construction. | ||
| * @see {@link FormattedTextAsTree.(Tree:class)} for schema. | ||
| * @see {@link FormattedTextAsTree.createSchema} for creating whose nodes implement this. |
Contributor
There was a problem hiding this comment.
Suggested change
| * @see {@link FormattedTextAsTree.createSchema} for creating whose nodes implement this. | |
| * @see {@link FormattedTextAsTree.createSchema} for creating schemas whose nodes implement this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make FormattedTextAsTree generic, moving special case to FormattedTextAsTreeDefault.
Reviewer Guidance
The review process is outlined on this wiki page.