Repository navigation
Add missing-tests meme guidance for Copilot reviews - #9043
Merged
Damyan Pepper (damyanp) merged 1 commit intoOct 16, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a003681e-c910-420c-a7e6-7b79d07bd97e
Chris B (llvm-beanz)
approved these changes
Oct 16, 2026
Chris B (llvm-beanz)
left a comment
Chris B (llvm-beanz)
left a comment
Collaborator
There was a problem hiding this comment.
10/10, best pull request ever.
That said, I can't take credit for this meme. It was made by someone in the LLVM community.
Member
|
I'm tempted to create a test-less PR just to try it out! :) |
Alex Sepkowski (alsepkow)
approved these changes
Oct 16, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The instructions match the intended scope with no identified blocking issues, though actual review behavior remains unverified.
0 open findings
What changed in this PR
Adds Copilot review guidance for functional changes that include no test changes.
Changes:
- Requests tests with a “TEST CASE?” meme in the review summary, at most once per PR.
- Defines exclusions and reserves specific review comments for incomplete coverage.
| File | Description |
|---|---|
.github/copilot-instructions.md |
Adds missing-test feedback rules and exclusions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep Copilot's missing-test feedback focused on clear omissions, using Chris's "TEST CASE?" seagulls meme when a functional change includes no test changes at all.
The review guidance posts the meme in the review summary alongside a brief request for tests, at most once per PR. Incomplete coverage gets a normal, specific review comment instead. Docs, infrastructure, dependency bumps, NFC refactors, and PRs explaining why tests are infeasible or linking related test coverage are excluded.
Instructions-only change; the behavior has not yet been exercised in a Copilot review.
Assisted by GitHub Copilot.