Automatically expire stale Pending node entries - #8173
Open
Amaury Chamayou (achamayou) with Copilot wants to merge 9 commits into
Open
Automatically expire stale Pending node entries#8173Amaury Chamayou (achamayou) with Copilot wants to merge 9 commits into
Amaury Chamayou (achamayou) with Copilot wants to merge 9 commits into
Conversation
Copilot
AI
changed the title
[WIP] Add automatic expiration for KV pending entries after delay
Automatically expire stale Pending node entries
Aug 18, 2026
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Chamayou (achamayou)
force-pushed
the
copilot/ccf-6672-node-expire-pending-entries
branch
from
August 26, 2026 12:07
b1a16f8 to
f8929e7
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
Copilot resolve the merge conflicts in this pull request |
…-expire-pending-entries # Conflicts: # tests/e2e_operations.py Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Contributor
Author
Resolved in |
Copilot started reviewing on behalf of
Amaury Chamayou (achamayou)
September 3, 2026 13:49
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Timestamp throttling can expire active joiners early, while the default and changelog placement conflict with stated requirements.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds primary-driven expiration of stale Pending node records, including configuration, persistence, cleanup, documentation, and tests.
Changes:
- Records and refreshes Pending-node timestamps.
- Periodically removes expired nodes and associated data.
- Adds host configuration, documentation, and test coverage.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/changelog.instructions.md.github/instructions/reviewing.instructions.md
File summaries
| File | Description |
|---|---|
tests/infra/remote.py |
Passes timeout into node configuration. |
tests/infra/network.py |
Forwards the new test argument. |
tests/e2e_operations.py |
Tests automatic expiration end-to-end. |
tests/config.jinja |
Renders the timeout setting. |
src/node/rpc/test/node_stub.h |
Adds configurable test subsystems. |
src/node/rpc/test/node_frontend_test.cpp |
Tests timestamp and cleanup behavior. |
src/node/rpc/test/frontend_test.cpp |
Reuses the shared configuration stub. |
src/node/rpc/node_frontend.h |
Tracks timestamps and removes expired entries. |
src/node/pending_node_cleanup.h |
Implements periodic primary cleanup. |
src/node/node_state.h |
Starts the cleanup task. |
src/common/configuration.h |
Registers configuration serialization. |
include/ccf/service/node_info.h |
Persists the last-seen timestamp. |
include/ccf/node/startup_config.h |
Defines the timeout default. |
doc/operations/start_network.rst |
Documents expiration behavior. |
doc/host_config_schema/host_config.json |
Adds the host configuration schema. |
CHANGELOG.md |
Announces the feature. |
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+610
to
+616
| const auto refresh_interval = | ||
| pending_node_timeout.value().count() / 2; | ||
| if ( | ||
| !node_info->pending_last_seen.has_value() || | ||
| node_info->pending_last_seen.value() < 0 || | ||
| node_info->pending_last_seen.value() > now || | ||
| now - node_info->pending_last_seen.value() >= refresh_interval) |
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsuccessful join attempts can leave Pending node records requiring manual operator cleanup. This adds configurable, primary-driven expiration.
Expiration
pending_node_timeout.Configuration
24h.0sto disable cleanup.{ "pending_node_timeout": "6h" }Compatibility
Integration