Repository navigation
[DX] Bump http-proxy-middleware@3 - #5924
Open
Patrick Sean Odugboche (Podugboch) wants to merge 1 commit into
Open
Patrick Sean Odugboche (Podugboch) wants to merge 1 commit into
Patrick Sean Odugboche (Podugboch) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The sample retains an unsupported two-argument proxy call that prevents development-server startup.
1 open issue
What changed in this PR
Updates the test harness and enterprise SSO sample toward http-proxy-middleware v3 compatibility, addressing #5178.
Changes:
- Removes the harness’s v2 pin and upgrades its dependency.
- Migrates proxy response events and the sample’s factory import.
- Adds a changelog entry.
| File | Description |
|---|---|
| samples/07.advanced-web-chat-apps/b.sso-for-enterprise/app/src/setupProxy.js | Uses the named proxy factory import. |
| packages/test/harness/src/host/jest-server/index.js | Migrates to on.proxyRes. |
| packages/test/harness/package.json | Removes the v2 pin and selects v3. |
| CHANGELOG.md | Documents the upgrade. |
Review effort: Balanced
| // Passthru-ing API traffic to /rest-api/ | ||
| module.exports = app => { | ||
| app.use(proxy('/api', { target: 'http://localhost:5000/' })); | ||
| app.use(createProxyMiddleware('/api', { target: 'http://localhost:5000/' })); |
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
http-proxy-middlewareto 3.0.0, fixes #5178, by @PodugbochDescription
Bumps
http-proxy-middlewareto version 3.0.0 across the test harness and sample proxy setups, migrating event listeners fromonProxyRestoon: { proxyRes: ... }required byhttp-proxy-middleware@3.Specific Changes
Removed
http-proxy-middleware@2frompackages/test/harness/package.json/pinDependenciesBumped
http-proxy-middlewareto^3.0.0inpackages/test/harness/package.jsonMigrated
onProxyReshandler toon: { proxyRes: ... }inpackages/test/harness/src/host/jest-server/index.jsUpdated
samples/07.advanced-web-chat-apps/b.sso-for-enterprise/app/src/setupProxy.jsto use namedcreateProxyMiddlewareimport consistent with other samplesAdded changelog entry in
CHANGELOG.mdI have added tests and executed them locallyI have updated
CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)