Repository navigation
Use the hour cycle of the locale in timestamps - #5920
Merged
Merged
Conversation
added 2 commits
October 19, 2026 13:33
The date formatter used the Globalize skeleton "MMMMdhm", where "h" forces the 12-hour clock in every locale (e.g. "8. August um 4:41 PM" in German). Use "j", the preferred hour cycle of the locale.
Eugene (OEvgeny)
marked this pull request as ready for review
October 19, 2026 21:37
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 19, 2026 21:37
William Wong (compulim)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
useDateFormatterused the Globalize skeletonMMMMdhm, wherehforces the 12-hour clock. It now usesMMMMdjm, wherejis the preferred hour cycle of the locale, so English stays "August 8 at 4:41 PM" and German becomes "8. August um 16:41".Design
jis supported by the bundled data, no switch toIntl.DateTimeFormatneeded.Specific Changes
useDateFormatter.ts,createPrecompiledGlobalize.mjs,types/PrecompiledGlobalize.ts: skeletonMMMMdhm→MMMMdjmtimestamp/absolute.hourCycle.html: snapshot 1, "August 8 at 4:41 PM" in en-US; snapshot 2, "8. August um 16:41" in de-DE; asserts the visible and "Sent at" textslocalization.fileUpload.polish.html: snapshot 1 updated, "6 września 8:49 PM" → "20:49"I have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed