Repository navigation
Keep activities from overlapping when the host styles section as a flex item - #5919
Draft
Eugene (OEvgeny) wants to merge 5 commits into
Draft
Eugene (OEvgeny) wants to merge 5 commits into
Eugene (OEvgeny) wants to merge 5 commits into
Conversation
added 2 commits
October 19, 2026 12:09
Collaborator
Author
|
TODO: does fluent adjust these settings cause it was a different defect with audio card growing past the card size. |
Eugene (OEvgeny)
marked this pull request as ready for review
October 19, 2026 21:37
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 19, 2026 21:37
Eugene (OEvgeny)
enabled auto-merge (squash)
October 19, 2026 22:02
Collaborator
Author
|
TODO: which element is section? |
Eugene (OEvgeny)
marked this pull request as draft
October 20, 2026 00:28
auto-merge was automatically disabled
October 20, 2026 00:28
Pull request was converted to draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
sectionas a flex item, in PR #5919, by @OEvgenyDescription
The activity list is a
<section>element (TranscriptActivityList, classtranscript-focus-area__activity-list), so a host type selector onsectionmatches it, and it shrinks to the transcript height; since its rows havemin-height: 0, the rows are squeezed and cards overlap (video controls and title hidden, since 4.19.0). The activity list now hasflex: none, so it keeps its content height, as it already does without such host CSS.Design
min-height: 0on the rows (added by feat: add preview of ongoing items in the group for copilot variant #5637) and only stopped the list from shrinking.Specific Changes
TranscriptFocus.module.css:flex: noneon.transcript-focus-area__activity-listtranscript/hostSectionStyle.html: hostsectionrule, video card + animation card, asserts each row fits its content and the cards do not overlap; snapshot 1 shows the whole video card (controls and title) above the animation cardCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed