Skip to content

Keep activities from overlapping when the host styles section as a flex item - #5919

Draft
Eugene (OEvgeny) wants to merge 5 commits into
mainfrom
OEvgeny/fix-transcript-host-section-shrink
Draft

Eugene (OEvgeny) wants to merge 5 commits into
mainfrom
OEvgeny/fix-transcript-host-section-shrink

Conversation

@OEvgeny

@OEvgeny Eugene (OEvgeny) commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Host page CSS such as section { display: flex; min-height: 0 } makes activities overlap in the default theme.

Changelog Entry

Fixed

  • Fixed activities overlapping in the default theme when the host page styles section as a flex item, in PR #5919, by @OEvgeny

Description

The activity list is a <section> element (TranscriptActivityList, class transcript-focus-area__activity-list), so a host type selector on section matches it, and it shrinks to the transcript height; since its rows have min-height: 0, the rows are squeezed and cards overlap (video controls and title hidden, since 4.19.0). The activity list now has flex: none, so it keeps its content height, as it already does without such host CSS.

Design

Specific Changes

  • TranscriptFocus.module.css: flex: none on .transcript-focus-area__activity-list
  • transcript/hostSectionStyle.html: host section rule, video card + animation card, asserts each row fits its content and the cards do not overlap; snapshot 1 shows the whole video card (controls and title) above the animation card
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny

Copy link
Copy Markdown
Collaborator Author

TODO: does fluent adjust these settings cause it was a different defect with audio card growing past the card size.

Comment thread packages/component/src/Transcript/TranscriptFocus/TranscriptFocus.module.css Outdated
@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review October 19, 2026 21:37
Copilot AI balanced review requested due to automatic review settings October 19, 2026 21:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@OEvgeny
Eugene (OEvgeny) enabled auto-merge (squash) October 19, 2026 22:02
@OEvgeny

Copy link
Copy Markdown
Collaborator Author

TODO: which element is section?

@OEvgeny
Eugene (OEvgeny) marked this pull request as draft October 20, 2026 00:28
auto-merge was automatically disabled October 20, 2026 00:28

Pull request was converted to draft

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants