Skip to content

Raise contrast of the Positive card action button to 4.5:1 - #5905

Merged
Eugene (OEvgeny) merged 4 commits into
mainfrom
OEvgeny/fix-5713-positive-contrast
Oct 19, 2026
Merged

Eugene (OEvgeny) merged 4 commits into
mainfrom
OEvgeny/fix-5713-positive-contrast

Conversation

@OEvgeny

@OEvgeny Eugene (OEvgeny) commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #5713

Changelog Entry

Fixed

  • Fixed the "Positive" card action button having less than 4.5:1 color contrast, fixes #5713, in PR #5905, by @OEvgeny

Description

The "Positive" card action button had white text on #0078d7, just under the 4.5:1 contrast required by WCAG 1.4.3, in the default and Fluent themes. It now uses #0078d4 (4.53:1), which looks the same.

Design

Specific Changes

  • AdaptiveCardRenderer.module.css: the background of the Positive button is #0078d4 instead of #0078d7

  • Added richCard/actionStyles.contrast.html and its Fluent variant: the "card actionstyles" card, in the transcript and outside of it, with the default accessibility check; fails on main with insufficient color contrast of 4.49

  • I have added tests and executed them locally

  • I have updated CHANGELOG.md

  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Eugene Olonov added 3 commits October 18, 2026 19:55
The Positive button was #0078d7 with white text (4.499:1, below WCAG 1.4.3).
Use #0078d4, the lightest close blue that passes, so it stays as distinct
from the selected action (#0063b1) as before.
The card is also rendered outside of the transcript, where the accessibility
check can measure its color contrast: inside the transcript, the transcript
focus overlays cover it and axe reports it as incomplete.
@OEvgeny
Eugene (OEvgeny) marked this pull request as ready for review October 19, 2026 03:18
Copilot AI balanced review requested due to automatic review settings October 19, 2026 03:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@OEvgeny
Eugene (OEvgeny) enabled auto-merge (squash) October 19, 2026 05:32
@OEvgeny
Eugene (OEvgeny) merged commit b938cf8 into main Oct 19, 2026
32 checks passed
@OEvgeny
Eugene (OEvgeny) deleted the OEvgeny/fix-5713-positive-contrast branch October 19, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[White Label -Card Actionstyles]: Luminosity ratio of Positive text is less than required ratio of 4.5:1.

3 participants