Skip to content

Enforce permissions when reviewing orphaned extension data#9569

Open
jhejlsberg wants to merge 1 commit into
mainfrom
private/jhejlsberg/orphaned-extension-data-permissions
Open

Enforce permissions when reviewing orphaned extension data#9569
jhejlsberg wants to merge 1 commit into
mainfrom
private/jhejlsberg/orphaned-extension-data-permissions

Conversation

@jhejlsberg

@jhejlsberg jhejlsberg commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What & why

Ensure marking orphaned extension data as reviewed consistently calls CheckPermissions() from both the notification and page actions.

Linked work

Fixes AB#633514

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

No tests added; both entry points now share the same implementation.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

  • Installed and uninstalled an extension; verified the orphaned-data notification appeared.
  • Marked data as reviewed from both the notification and the Delete Orphaned Extension Data page; verified the reviewed status was updated.
  • Reinstalled and uninstalled the extension; verified the reviewed status was reset.

Risk & compatibility

Permission enforcement is stricter on OpenPage.

@jhejlsberg
jhejlsberg requested review from a team July 17, 2026 08:38
@github-actions github-actions Bot added AL: System Application Integration GitHub request for Integration area labels Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

All 16 sub-skills completed; the two-file diff (permission-check extraction in Extension Operation Impl) was evaluated against every domain's knowledge worklist with no violations found, and the cross-cutting self-review pass surfaced no additional concerns.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: System Application Integration GitHub request for Integration area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants