[Expense Agent] Remove migration TODO and analyzer suppressions

[Prangshuman Das (t-prda)]

Summary

• remove the stale Expense Agent annotation TODO while preserving the intentionally empty annotation result
• remove the obsolete AS0031 suppressions from the setup pages
• replace the broad AA0073 suppression with compliant temporary-record variable names

Validation

• built Expense Agent with the BCApps ruleset and code analyzers
• published local build 30.0.54587.0 to W1 tenant tenant1-1
• no runtime tests added or run because the change does not alter behavior

Fixes AB#644961

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change removes a stale annotation TODO while keeping the intentionally empty annotation result. It also removes broad page-level analyzer suppressions and renames temporary-record variables so the analyzer can stay enabled. The code paths for setup loading, agent state persistence, and mailbox validation keep the same calls and state transitions, so the cleanup appears behavior-preserving.

Problem-solution fit

Fit: Strong

The diff addresses the described cleanup points directly: the unresolved TODO is gone, the broad suppressions are removed, and the temporary-record naming now matches the temporary buffer and email account records. The scope is limited to those cleanup changes.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: Low. The main regression surface is the Expense Agent setup wizard enable/disable flow and mailbox validation, but the change only renames variables and removes suppressions while preserving the same procedure calls and record operations.

Necessity: The cleanup is needed to remove stale migration debt and let analyzer warnings surface again. The scope is appropriate because it only touches the flagged TODO and suppressions.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11682 round=1 by=alexei-dobriansky at=2026-09-22T01:09:32.8436977Z lastSha=9be3ebb59a59137721eba6a62d5ab690ae6dc3fd reviewKey=5ea8270364afec30a737fa97862b2740f2a14ecefb257515cb9771e6e8e42a66 suggestions=none