Fix quantity fields on Sales Return Order Archive - #11667
Draft
attilatoury wants to merge 1 commit into
Draft
attilatoury wants to merge 1 commit into
attilatoury wants to merge 1 commit into
Conversation
Show stored return receipt quantities and hide the retained shipment controls. Add snapshot-specific page regression coverage in W1 and ES. AB#650778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The Sales Return Order Archive lines show ordinary shipment quantities instead of return-receipt quantities.
Return Qty. to ReceiveandReturn Qty. Receivedto page 6628, bound directly to the selectedSales Line Archiverecord, with snapshot-specific tooltips.Qty. to ShipandQuantity Shippedby default while retaining their controls for page-extension compatibility.SCM Archive Orders, propagated to the ES layer.No table, data migration, posting, archive timing, or invoiced-quantity behavior changes. The separate final-invoice archive-quantity concern is outside this PR's scope.
Linked work
AB#650778 — Sales Return Order Archive displays shipment quantities instead of return receipt quantities
How I validated this
What I tested and the outcome
git diff --check, scoped Miapp propagation, andAssert-GDLViewIsClean -CountryCode W1passed. Static checks confirmed the direct return-field bindings, hidden shipment controls, and identical W1/ES test additions without removing country-specific code.SalesReturnOrderArchiveShowsStoredReturnQuantitiesin codeunit 137207. It creates two archive snapshots with return quantities 2/0 and 0/2, verifies page values against the full archived-line key, checks invoice quantities remain 2/0 and shipment controls are hidden, then reopens the first snapshot. The received state is modeled in the fixture without posting; this is page/snapshot coverage, not a posting test. Receipt quantity is explicitly validated to avoid dependence on the company's default quantity setup.AL1022, compatibleMicrosoft System 30.0.0.0symbols unavailable. A fresh local endpoint download returned System29.0.54249.0; System Application and Business Foundation returned30.0.54539.0. No manifest downgrade or production workaround was applied.Risk & compatibility