Skip to content

Fix quantity fields on Sales Return Order Archive - #11667

Draft
attilatoury wants to merge 1 commit into
mainfrom
private/attilatoury/fix-650778-sales-return-archive
Draft

attilatoury wants to merge 1 commit into
mainfrom
private/attilatoury/fix-650778-sales-return-archive

Conversation

@attilatoury

@attilatoury attilatoury commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

What & why

The Sales Return Order Archive lines show ordinary shipment quantities instead of return-receipt quantities.

  • Add Return Qty. to Receive and Return Qty. Received to page 6628, bound directly to the selected Sales Line Archive record, with snapshot-specific tooltips.
  • Hide Qty. to Ship and Quantity Shipped by default while retaining their controls for page-extension compatibility.
  • Add focused page regression coverage to SCM Archive Orders, propagated to the ES layer.

No table, data migration, posting, archive timing, or invoiced-quantity behavior changes. The separate final-invoice archive-quantity concern is outside this PR's scope.

Linked work

AB#650778Sales Return Order Archive displays shipment quantities instead of return receipt quantities

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

  • git diff --check, scoped Miapp propagation, and Assert-GDLViewIsClean -CountryCode W1 passed. Static checks confirmed the direct return-field bindings, hidden shipment controls, and identical W1/ES test additions without removing country-specific code.
  • Added SalesReturnOrderArchiveShowsStoredReturnQuantities in codeunit 137207. It creates two archive snapshots with return quantities 2/0 and 0/2, verifies page values against the full archived-line key, checks invoice quantities remain 2/0 and shipment controls are hidden, then reopens the first snapshot. The received state is modeled in the fixture without posting; this is page/snapshot coverage, not a posting test. Receipt quantity is explicitly validated to avoid dependence on the company's default quantity setup.
  • A local Base Application compilation with CodeCop configured was attempted but stopped at dependency resolution: AL1022, compatible Microsoft System 30.0.0.0 symbols unavailable. A fresh local endpoint download returned System 29.0.54249.0; System Application and Business Foundation returned 30.0.54539.0. No manifest downgrade or production workaround was applied.
  • Full compilation/analyzer validation and SCM test execution remain outstanding. No runtime tests, deployment, or manual UI validation were performed. This PR is intentionally draft.

Risk & compatibility

  • Existing shipment controls are retained, only hidden by default; personalization or extensions can still expose them.
  • The page displays stored values from each selected archive version. Earlier snapshots are not recalculated or rewritten.
  • No schema, posting, or financial behavior changes. No new AL object IDs.
  • Complete compilation and focused runtime/UI validation before marking ready for review.

Show stored return receipt quantities and hide the retained shipment controls. Add snapshot-specific page regression coverage in W1 and ES.

AB#650778
@github-actions github-actions Bot added the Team: SCM GitHub request for SCM area label Sep 21, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant