Add OnBefore event for approval insertion checks - #11664
Open
Darrick (darjoo) wants to merge 1 commit into
Open
Darrick (darjoo) wants to merge 1 commit into
Darrick (darjoo) wants to merge 1 commit into
Conversation
Allow subscribers to bypass record conversion and approval checks using IsHandled while preserving the existing unhandled behavior. AB#606350 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Darrick (darjoo)
marked this pull request as ready for review
September 21, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Extensions cannot currently skip journal insertion approval checks, even when approvals are not used. Add
OnBeforePreventInsertRecIfOpenApprovalEntryExist(Variant: Variant; var IsHandled: Boolean)toApprovals Mgmt.before record conversion and approval checks. Subscribers can setIsHandledto bypass the procedure; otherwise, its existing logic is unchanged.Linked work
Fixes microsoft/ALAppExtensions#29214
AB#606350
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
git diff --checkpassed.IsHandledinitialized to false, and the handled exit beforeRecRef.GetTable. Removing the new guard and publisher reproduced the original source, confirming the existing approval logic was not changed.Risk & compatibility
Additive integration event. Existing approval and cancellation behavior is unchanged unless a subscriber explicitly handles the event. No schema, permission, or upgrade changes.