Skip to content

Bug 649818: [29x][NAV] Track Translation update (AUTODETECTED) - #11655

Open
Bardur Knudsen (BardurKnudsen) wants to merge 2 commits into
releases/29.xfrom
bugs/649818-demotool_29x
Open

Bardur Knudsen (BardurKnudsen) wants to merge 2 commits into
releases/29.xfrom
bugs/649818-demotool_29x

Conversation

@BardurKnudsen

@BardurKnudsen Bardur Knudsen (BardurKnudsen) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Added call to company initialize for robustness.

Fixes AB#649818

@BardurKnudsen Bardur Knudsen (BardurKnudsen) changed the title Bugs/649818 demotool 29x Bug 649818: [29x][NAV] Track Translation update (AUTODETECTED) Sep 21, 2026
@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 21, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 21, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This PR adds a General Ledger Setup existence check before importing demo data configuration. If setup is missing, it runs company initialization first and then continues with the existing demo data setup flow across the affected layer copies.

Problem-solution fit

Fit: Strong

The change directly addresses the fresh-company setup path where demo data creation can run before required setup records exist. The guard avoids changing already initialized companies.

Suggestions

None.

Risk assessment and necessity

Risk: The touched surface is demo data setup. The change can create standard setup records through existing company initialization, but only when General Ledger Setup is missing; it does not change posting logic, public APIs, or normal initialized companies.

Necessity: A fix is needed so demo data setup works in fresh or partially initialized companies. The scope is narrow and consistent across the affected implementations.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11655 round=1 by=alexei-dobriansky at=2026-09-21T20:16:34.0153998Z lastSha=08deda8ea72200443dc0f613e73c42079af33bdb reviewKey=49718a101e4b523573581b3757fc94154da6ba20e1dbd09965d8af6b32e7a58b suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants