Skip to content

[MAIN]: When receiving a payment from an SEZ (Special Economic Zone) customer under the "Without Payment of Duty" scenario, GST is being calculated incorrectly in the Bank Receipt Voucher in the Indian version. - #11648

Open
Tabrez Ajaz (v-ajaztabrez) wants to merge 1 commit into
mainfrom
bugs/Bug-650742-Main-When-receiving-payment-from-an-SEZ-Without-Payment-of-Duty

Conversation

@v-ajaztabrez

@v-ajaztabrez Tabrez Ajaz (v-ajaztabrez) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

(AB#650742)
Bug 650742: [Main]-When receiving a payment from an SEZ (Special Economic Zone) customer under the "Without Payment of Duty" scenario, GST is being calculated incorrectly in the Bank Receipt Voucher in the Indian version.

Issue:
For an SEZ customer transaction created through Bank Receipt Voucher, enabling GST Without Payment of Duty did not immediately recalculate GST. After recalculation, IGST became zero, but GST Ledger Entry, Detailed GST Ledger Entry, and Detailed GST Ledger Entry Information were not generated during posting.

Cause:
The Bank Receipt Voucher page did not invoke the tax engine when GST Without Payment of Duty was validated. Additionally, the existing SEZ General Journal use case for transactions without payment of duty calculated IGST instead of zero and lacked the required GST posting configuration and posting-table metadata.

Solution:
Added tax-engine recalculation when GST Without Payment of Duty is validated on Bank Receipt Voucher. Updated the existing SEZ General Journal use case to calculate zero IGST while retaining GST ledger posting definitions, added the required GST Posting Setup table metadata, and increased the use-case version so the updated configuration is imported during deployment.

@v-ajaztabrez
Tabrez Ajaz (v-ajaztabrez) requested a review from a team as a code owner September 21, 2026 09:40
@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 21, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 21, 2026
@v-ajaztabrez Tabrez Ajaz (v-ajaztabrez) changed the title [28.x]: When receiving a payment from an SEZ (Special Economic Zone) customer under the "Without Payment of Duty" scenario, GST is being calculated incorrectly in the Bank Receipt Voucher in the Indian version. [MAIN]: When receiving a payment from an SEZ (Special Economic Zone) customer under the "Without Payment of Duty" scenario, GST is being calculated incorrectly in the Bank Receipt Voucher in the Indian version. Sep 21, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

This PR adds tax-engine recalculation when GST Without Payment of Duty is validated on Bank Receipt Voucher and updates the SEZ without-duty GST use case so IGST is zero while GST ledger records are still posted. It also adds posting metadata for detailed GST ledger records.

Problem-solution fit

Fit: Partial

The reported scenario is valid and the recalculation hook is in the right area. The posting metadata still stores a customer receipt with a vendor source type, and one sample also found an uncovered sibling SEZ path, so the fix is not safe as-is.

Suggestions

S1 (🔴 High): Use customer source type for sales entry
The Detailed GST Ledger Entry uses Transaction Type = Sales and Source No. from the customer account, but the new Source Type value is Vendor. Change it to Customer; otherwise posted GST details for this receipt are stored with the wrong source type.

S2 (🔴 High): Cover the sibling SEZ path
The fix updates only the SEZ Unit use case. The without-duty flow can also use the matching SEZ Development setup, so update that sibling use case too or make the scope explicit if that customer type is not affected.

Risk assessment and necessity

Risk: This is a financial tax posting path. Wrong use-case metadata can persist incorrect GST ledger source classification even when the tax amount is zero.

Necessity: The fix is needed so SEZ without-duty receipts recalculate to zero IGST and still produce statutory GST ledger artifacts. The posting configuration must be corrected before merge.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11648 round=1 by=alexei-dobriansky at=2026-09-21T20:24:01.0824613Z lastSha=c8bab9d61ab7d1ab4a8e86e98ade9859a66a87f2 reviewKey=67b218b482ebdb8121860faad5dc5cc3b8c19892755e99351ae65be19346c754 suggestions=S1@b7d173ed,S2@b7d173ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants