Skip to content

[Subcontracting] Bug 648937: Transfer WIP Item is lost when production orders are created from Planning Worksheet - #11644

Open
Chethan Thopaiah (ChethanT) wants to merge 2 commits into
mainfrom
investigate/648937
Open

Chethan Thopaiah (ChethanT) wants to merge 2 commits into
mainfrom
investigate/648937

Conversation

@ChethanT

@ChethanT Chethan Thopaiah (ChethanT) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve Transfer WIP Item and transfer descriptions on Planning Routing Line
  • propagate the values from routing lines through Planning Worksheet carry-out to production order routing lines
  • cover both certified routing versions and base routings with integration tests

Testing

  • Added tests to codeunit 139996 Subc. Planning Test
  • Verified patch formatting and object ID uniqueness
  • Build and test execution were not available in the current environment

Fixes AB#648937

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cb368c63-4b66-4ace-824e-f59c37adf44f
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: SCM GitHub request for SCM area labels Sep 21, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 21, 2026
@ChethanT
Chethan Thopaiah (ChethanT) marked this pull request as ready for review September 21, 2026 09:07
@ChethanT Chethan Thopaiah (ChethanT) added the Subcontracting Subcontracting related activities label Sep 21, 2026
@ChethanT Chethan Thopaiah (ChethanT) changed the title [Subcontracting] Preserve Transfer WIP Item through planning [Subcontracting] Bug 648937: Preserve Transfer WIP Item through planning Sep 21, 2026
@ChethanT Chethan Thopaiah (ChethanT) changed the title [Subcontracting] Bug 648937: Preserve Transfer WIP Item through planning [Subcontracting] Bug 648937: Transfer WIP Item is lost when production orders are created from Planning Worksheet Sep 21, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cb368c63-4b66-4ace-824e-f59c37adf44f
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

This PR adds storage on Planning Routing Line for Transfer WIP Item and transfer descriptions, then copies those values from routing lines through Planning Worksheet carry-out into production order routing lines. The data flow matches the reported bug, and the selected BaseApp events fire at the right points: before the planning routing line is inserted and after the production order routing line has copied the planning routing values.

Problem-solution fit

Fit: Strong

The change directly addresses the missing planning-routing storage and propagation path. It covers both routing versions and base routings, which matches the two ways the affected value can be sourced.

Suggestions

S1 (🔴 High): Fix the failing base-routing test
The new base-routing test currently fails while carrying out the planning line because production order GU00000000 already exists. Fix the test setup or cleanup so the carry-out creates a unique firm planned order and the subcontracting test app is stable. The failure also makes later planning tests unstable in the same app.

Risk assessment and necessity

Risk: The product code is narrow, but it changes subcontracting planning-to-production data flow. If it is wrong, production orders created from Planning Worksheet can still miss WIP transfer behavior or carry wrong transfer descriptions. The current validation failure is the main remaining merge risk.

Necessity: The change is required so orders created from Planning Worksheet preserve Transfer WIP Item the same way direct production order refresh does. Without it, the transfer-WIP process can silently be skipped for planned subcontracting orders.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11644 round=1 by=alexei-dobriansky at=2026-09-21T12:12:22Z lastSha=2007eeaebd8c273368f782f5459379abcd5e1ebe reviewKey=8d65aadb2a4eda05ef96a095a4cde6de992aab1213a2665885e2f8826320144d suggestions=S1@80e57013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Subcontracting Subcontracting related activities Team: SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants