Align Expense setup obsoletion with release 29 - #11643
Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
Draft
Prangshuman Das (t-prda) wants to merge 1 commit into
Prangshuman Das (t-prda) wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Align the Expense Agent setup-page obsoletion boundaries on
mainwith the first release that contains them. Original #11541 introduced these boundaries asCLEAN30/30.0; merged backports #11613 (releases/29.x) and #11614 (releases/29.0) introduced the same obsoletions in release 29.This changes only
src/Apps/W1/ExpenseAgent/app/src/Setup/Pages/ExpenseAgentSetup.Page.al: exactly sevenCLEAN30guards becomeCLEAN29, and exactly 20ObsoleteTag = '30.0'values become29.0. The affected hidden controls/groups cover agent activation, receipt submission, outgoing communication and reminders, policy evaluation, projects, and shortest routes, plus their guarded helper/label. Existing release-29 obsoletions are untouched.Prepared from fresh
maincommit00e995d263ccd6eb50cf85d5a28d5704a1b89e66, not an old feature branch. Keep this PR draft until the compatibility baseline contains the merged release-29 obsoletions and CI verifies the alignment. Baseline synchronization may take several days; this PR does not assert that it has happened.Linked work
AB#640269 — informational link to the original, already-resolved source work; this PR does not reopen or resolve it again.
Original merged PR: #11541 (
9f382f608fab7e117cfeb1e33fa9f70259386bfa).Merged release backports: #11613 (
a66254c3b8b5bb1cea290dc8f9d097aec4381153) and #11614 (655a715dc7a7960d7e8a1f96d434d4abc1fc1d8f).No new GitHub issue is linked: this is the follow-up alignment of the existing Microsoft work item and merged PRs above.
How I validated this
What I tested and the outcome
git diff --checkpassed.Risk & compatibility
The cleanup boundary intentionally moves earlier to release 29, matching when the public controls/groups were first made Pending by the merged backports. Normal builds with cleanup symbols unset retain the same controls and statements; builds defining
CLEAN29now exclude these obsolete controls and their helper/label.At preparation time,
build/Packages.jsonpinsAppBaselines-BCArtifactsto29.1.54166.0. That package's presence alone does not prove that it includes the backports. Keep draft pending compatibility-baseline verification and successful required CI checks. No baseline files, diagnostics, manifests/versions, schemas, object IDs, tests, or unrelated behavior were changed. This does not include any email-lifecycle changes from #11615, and does not enable automatic merge or mark the PR ready.