[Shopify] Add GraphQL type to request telemetry - #11611
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8406292a-57b3-4411-a15c-8094f405a361
Good Sense Reviewer - Round 1Recommendation: Request ChangesWhat this PR doesThis adds a The main path is correct for callers that use the enum overload. It does not cover typed queries that are first read with Problem-solution fitFit: Partial The change matches the requested telemetry shape for normal enum-based GraphQL calls, and it preserves empty values for untyped calls. It only solves part of the reported scenario because some typed query executions still go through the raw-text overload after the query type is already known. SuggestionsS1 (🔴 High): Carry the type through all typed requests Risk assessment and necessityRisk: The behavior change is limited to telemetry dimensions for Shopify HTTP requests and is additive, so request execution and existing dimensions should stay compatible. The regression risk is mainly diagnostic accuracy: if this merges as-is, some query families remain grouped under an empty value. Necessity: The change is needed because the shared GraphQL endpoint makes URL-based telemetry grouping too coarse. The scope should include every code path that already knows the GraphQL enum before executing the request.
|
|
Pull request was closed
What & why
Adds a
GraphQL Typecustom dimension to Shopify request telemetry event0000K8W. Typed GraphQL requests emit the stable, nonlocalized enum value name; raw or untyped requests emit an empty value. The value is passed through the HTTP and GraphQL retry paths so telemetry can be grouped by query type without exposing query contents or variables.Linked work
Fixes AB#650502
How I validated this
What I tested and the outcome
Session.LogMessageevent or retry flow.Risk & compatibility
Low. Existing
0000K8Wdimensions and request behavior are unchanged; the new custom dimension is additive. Untyped requests report an empty value.