Map do.md severities (blocker/major/minor) in Severity.from_input#750
Merged
Conversation
The production review engine emits blocker|major|minor|info per BCQuality skills/do.md, but _SEVERITY_ALIASES only knew error|warning|suggestion|info, so blocker/major/minor coerced to unspecified severity and were dropped from severity_mae. Add blocker->critical, major->high, minor->low.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds BCQuality severity aliases to preserve severity scoring in code-review evaluations.
Changes:
- Maps
blocker,major, andminorto canonical severities. - Adds unit coverage for each mapping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/bcbench/dataset/codereview.py |
Adds BCQuality severity aliases. |
tests/test_codereview.py |
Tests the new mappings. |
Groenbech96
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Map the BCQuality
skills/do.mdseveritiesblocker,major, andminorto the canonical BC-Bench severities inSeverity.from_input:blocker->criticalmajor->highminor->lowWhy
The production AL review engine (via
Invoke-LocalReview.ps1/ do.md contract) emits findings with severitiesblocker | major | minor | info. BC-Bench's_SEVERITY_ALIASESonly recognizederror | warning | suggestion | info, soblocker,major, andminorraisedValueErrorand were silently coerced to unspecified severity. The finding still counted toward precision/recall, but its severity was dropped, soseverity_maewas computed against the wrong (missing) value.This closes the severity gap that surfaces when scoring engine output through the code-review pipeline. It is independent of the engine-adapter alignment work and can merge on its own.
Tests
Extended
TestSeverity::test_aliases_map_to_canonical_severitieswith the three new aliases.pytest tests/test_codereview.py::TestSeveritypasses (7/7);ruff checkclean.