Repository navigation
Wait for stable private DNS before configuring certificate storage - #5243
Merged
Jay W (JayDoubleu) merged 2 commits intoOct 12, 2026
Conversation
This was referenced Oct 11, 2026
Jay W (JayDoubleu)
marked this pull request as ready for review
October 11, 2026 20:35
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The infrastructure logic is sound, but live certificate provisioning and Airlock validation remain pending.
0 open findings
What changed in this PR
Adds bounded private DNS and TLS readiness checks before certificate storage static-website configuration.
Changes:
- Requires seven consecutive private-endpoint checks within five minutes.
- Adds comprehensive readiness-script tests and CI routing.
- Bumps the certificate bundle to
0.7.14and updates release notes.
| File | Description |
|---|---|
templates/shared_services/certs/terraform/staticweb.tf |
Gates static-website configuration on endpoint readiness. |
templates/shared_services/certs/scripts/wait_for_private_storage.py |
Implements DNS and verified TLS checks. |
templates/shared_services/certs/porter.yaml |
Bumps the bundle version. |
devops/tests/test_certificate_storage_readiness.py |
Tests readiness, timeout, and failure behavior. |
CHANGELOG.md |
Records the certificate provisioning fix. |
.github/workflows/build_validation_develop.yml |
Runs deployment-script tests for certificate changes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jay W (JayDoubleu)
added this pull request to stack #5244
October 11, 2026 20:55
This was referenced Oct 11, 2026
This was referenced Oct 11, 2026
Jay W (JayDoubleu)
removed this pull request from stack #5244
October 11, 2026 22:27
Jay W (JayDoubleu)
added this pull request to stack #5247
October 11, 2026 22:29
Jay W (JayDoubleu)
force-pushed
the
feature/v0.30.0/airlock-deletion-evidence
branch
from
October 11, 2026 23:09
d754e11 to
b1ba008
Compare
Jay W (JayDoubleu)
force-pushed
the
feature/v0.30.0/certificate-storage-readiness
branch
from
October 11, 2026 23:09
d418498 to
1c68171
Compare
Jay W (JayDoubleu)
removed this pull request from stack #5247
October 12, 2026 21:40
Jay W (JayDoubleu)
force-pushed
the
feature/v0.30.0/airlock-deletion-evidence
branch
from
October 12, 2026 21:41
b1ba008 to
9a8ae08
Compare
Jay W (JayDoubleu)
force-pushed
the
feature/v0.30.0/certificate-storage-readiness
branch
from
October 12, 2026 21:41
1c68171 to
8cd1682
Compare
Base automatically changed from
feature/v0.30.0/airlock-deletion-evidence
to
feature/v0.30.0/ohdsi-validation
October 12, 2026 21:41
Jay W (JayDoubleu)
merged commit Oct 12, 2026
8cd1682
into
feature/v0.30.0/ohdsi-validation
1 check passed
Jay W (JayDoubleu)
deleted the
feature/v0.30.0/certificate-storage-readiness
branch
October 12, 2026 21:41
Jay W (JayDoubleu)
restored the
feature/v0.30.0/certificate-storage-readiness
branch
October 12, 2026 21:43
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certificate provisioning repeatedly blocked Airlock preparation when Terraform's static-website request returned a reset connection. The failed Airlock run and certificate diagnostics showed unstable storage DNS answers after private-endpoint creation.
Description:
Validation
CI for this PR's commit
1c68171fpassed.f957b6bc, readiness and static-website configuration passed. Certificate issuance then hit a separate ACME limit.c486c015, certificate deployment and cleanup passed with 23 smoke tests. This run also includes the certificate-reuse fix.The diagnostics support a DNS readiness problem, but did not capture the failed provider connection. #5246 addresses the separate issuance limit.
Fixes #5240. Related: #5158.