Skip to content

Wait for stable private DNS before configuring certificate storage - #5243

Merged
Jay W (JayDoubleu) merged 2 commits into
feature/v0.30.0/ohdsi-validationfrom
feature/v0.30.0/certificate-storage-readiness
Oct 12, 2026
Merged

Jay W (JayDoubleu) merged 2 commits into
feature/v0.30.0/ohdsi-validationfrom
feature/v0.30.0/certificate-storage-readiness

Conversation

@JayDoubleu

@JayDoubleu Jay W (JayDoubleu) commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator

Certificate provisioning repeatedly blocked Airlock preparation when Terraform's static-website request returned a reset connection. The failed Airlock run and certificate diagnostics showed unstable storage DNS answers after private-endpoint creation.

Description:

  • Require seven consecutive private DNS and verified TLS checks before Terraform configures the storage static website.
  • Probe the expected private IP with hostname verification. Check every five seconds and stop after five minutes if readiness is not established.
  • Repeat the check when the endpoint, private IP or probe changes. Preserve the existing private networking and firewall scope.

Validation

CI for this PR's commit 1c68171f passed.

Check Result Coverage
Deployment regressions 281 passed Includes readiness, incorrect DNS answers, TLS failures, bounded waits and replacement triggers.
Certificate bundle Build passed The changed bundle builds with the readiness dependency.
First live deployment Storage step passed At f957b6bc, readiness and static-website configuration passed. Certificate issuance then hit a separate ACME limit.
Certificate lifecycle retest 1 case passed At c486c015, certificate deployment and cleanup passed with 23 smoke tests. This run also includes the certificate-reuse fix.

The diagnostics support a DNS readiness problem, but did not capture the failed provider connection. #5246 addresses the separate issuance limit.

Fixes #5240. Related: #5158.

@JayDoubleu Jay W (JayDoubleu) added the v0.30.0-prep-v2 Current v0.30.0 preparation: stacked PRs and open follow-up issues. Keep after closure. label Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 1c68171. ± Comparison against base commit b1ba008.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The infrastructure logic is sound, but live certificate provisioning and Airlock validation remain pending.

0 open findings

What changed in this PR

Adds bounded private DNS and TLS readiness checks before certificate storage static-website configuration.

Changes:

  • Requires seven consecutive private-endpoint checks within five minutes.
  • Adds comprehensive readiness-script tests and CI routing.
  • Bumps the certificate bundle to 0.7.14 and updates release notes.
File Description
templates/​shared_services/​certs/​terraform/​staticweb.tf Gates static-website configuration on endpoint readiness.
templates/​shared_services/​certs/​scripts/​wait_for_private_storage.py Implements DNS and verified TLS checks.
templates/​shared_services/​certs/​porter.yaml Bumps the bundle version.
devops/​tests/​test_certificate_storage_readiness.py Tests readiness, timeout, and failure behavior.
CHANGELOG.md Records the certificate provisioning fix.
.github/​workflows/​build_validation_develop.yml Runs deployment-script tests for certificate changes.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread templates/shared_services/certs/scripts/wait_for_private_storage.py Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Current-head checks are pending, and a complete live certificate lifecycle remains unvalidated.

0 open findings

🧠 Review effort: Balanced

@JayDoubleu
Jay W (JayDoubleu) removed this pull request from stack #5244 October 11, 2026 22:27
@JayDoubleu
Jay W (JayDoubleu) added this pull request to stack #5247 October 11, 2026 22:29
@JayDoubleu
Jay W (JayDoubleu) force-pushed the feature/v0.30.0/airlock-deletion-evidence branch from d754e11 to b1ba008 Compare October 11, 2026 23:09
@JayDoubleu
Jay W (JayDoubleu) force-pushed the feature/v0.30.0/certificate-storage-readiness branch from d418498 to 1c68171 Compare October 11, 2026 23:09
@JayDoubleu
Jay W (JayDoubleu) removed this pull request from stack #5247 October 12, 2026 21:40
@JayDoubleu
Jay W (JayDoubleu) force-pushed the feature/v0.30.0/airlock-deletion-evidence branch from b1ba008 to 9a8ae08 Compare October 12, 2026 21:41
@JayDoubleu
Jay W (JayDoubleu) force-pushed the feature/v0.30.0/certificate-storage-readiness branch from 1c68171 to 8cd1682 Compare October 12, 2026 21:41
Base automatically changed from feature/v0.30.0/airlock-deletion-evidence to feature/v0.30.0/ohdsi-validation October 12, 2026 21:41
@JayDoubleu
Jay W (JayDoubleu) merged commit 8cd1682 into feature/v0.30.0/ohdsi-validation Oct 12, 2026
1 check passed
@JayDoubleu
Jay W (JayDoubleu) deleted the feature/v0.30.0/certificate-storage-readiness branch October 12, 2026 21:41
@JayDoubleu
Jay W (JayDoubleu) restored the feature/v0.30.0/certificate-storage-readiness branch October 12, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.30.0-prep-v2 Current v0.30.0 preparation: stacked PRs and open follow-up issues. Keep after closure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certificate static website provisioning intermittently fails on private storage access

3 participants