refactor: remove redundant HasPrefix check before TrimPrefix - #532
Merged
Harsh4902 merged 2 commits intoSep 21, 2026
Merged
Conversation
Signed-off-by: ish-g09 <ig.valiente09@gmail.com>
Vaishnav88sk
previously requested changes
Sep 18, 2026
Signed-off-by: ish-g09 <ig.valiente09@gmail.com>
Contributor
|
LGTM 👍🏻 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###Description
strings.TrimPrefixwithfilepath.Clean(f)to provide robust path normalisation (handling redundant prefixes like././and platform-specific path separators such as Windows.\) forfsnotifywatch events###Related issue(s)
Fixes #526
###AI Disclosure
The code change was written and verified by me, I fully understand it.
Testing
go build ./...: passesgo test ./...: all packages pass