fix the end-of-run save and clean up finish() across both engines - #445
Merged
Conversation
added 7 commits
July 21, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finish() saved whenever saving was requested, even when the run aborted during
setup or produced no images. On an abort the datastore has no summary metadata,
so save() threw an NPE (surfacing as "Error during acquisition cleanup"), and
every failed acquisition left an empty save folder behind.
Add acquisitionStarted_ to the base AcquisitionEngine: set true only after setup()
succeeds (right before run()) and reset in the innermost finally, so both engines
share one flag with no drift. Gate the save in both finish() methods on
acquisitionStarted_ && datastore_.getNumImages() > 0. getNumImages() is reliable
here because run() calls waitForCompletion() before returning, so all images are
drained before finish() checks the count.