Fix for extra 5 s stage scan time due to reading stale stage scan state value - #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@oleksiievetsno noticed an extra delay in stage scan. #404 was closed, but the delay turned out to be real, this is the fix.
The 1.4 plugin forces a fresh read of the stage-scan state (via RefreshPropertyValues); the LSM port was reading the cached value, which never updates to IDLE, so the cleanup wait always ran the full 5 s timeout and fell through to a forced Force-set XY stage scan to IDLE.
CoreLog validation: the 5 s tax is gone (stage-scan runs dropped from ~8500 ms to ~4600 ms, and the Force-set… fallback no longer fires):