Add greppable markers to CoreLog for all microscope geometries; elapsed time report even during errors - #439
Merged
Merged
Conversation
added 4 commits
July 20, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores functionality to LSM from the 1.4 diSPIM plugin:
There are some known errors that relate to hangs in
run(), the solution for those problems is more involved and will be revisited when working on other issues, so a hang inrun()wont showLSM-ACQ-STOPright now.The
LSM-ACQ-START/LSM-ACQ-STOPmarkers bracket every acquisition, so onesedpulls a single run's window straight out of a CoreLog, no tooling required:sed -n '/LSM-ACQ-START 4 /,/LSM-ACQ-STOP 4 /p' CoreLog.txtIf you want line numbers you can use
grep.Because
LSM-ACQ-STOPtimes the whole acquisition window (not just the imaging body), per-mode overhead is obvious at a glance. From one five-run session:The stage-scan run is ~5.6 s longer than the others, an extra delay in the stage-scan cleanup path that's easy to miss but jumps right out once each run's full window is timed. (The old per-engine "acquisition took" line measured only the imaging body, so it hid this.)
Surfaced a stage-scan cleanup delay; fix in the next PR, this was discovered as a result of the #404 CoreLog that @oleksiievetsno posted.