Fix 'microxrcedds_agent' name and dependency - #279
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
|
@mergify backport kilted jazzy humble |
✅ Backports have been createdDetails
Cherry-pick of 5e42d6a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 5e42d6a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Fix 'microxrcedds_agent' name and dependency * Set tag of 'microxrcedds_agent' --------- (cherry picked from commit 5e42d6a) Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
* Fix 'microxrcedds_agent' name and dependency (#279) Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit 5e42d6a) * Fix conflicts Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
* Fix 'microxrcedds_agent' name and dependency (#279) Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> (cherry picked from commit 5e42d6a) * Fix conflicts Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> --------- Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com> Co-authored-by: David Laseca Perez <davidlaseca@eprosima.com>
micro-ROS-Agent's humble branch now declares a package.xml dependency on microxrcedds_agent (micro-ROS/micro-ROS-Agent#279, backported in #282). That name is not a rosdep key in any ROS distribution, so rosdep install aborts with: micro_ros_agent: Cannot locate rosdep definition for [microxrcedds_agent] and every colcon build/test run has failed at the rosdep step since. The agent's SuperBuild.cmake still clones and builds Micro-XRCE-DDS-Agent itself when it is not already installed, so nothing is actually missing. Skip the key, which is what micro-ROS's own micro_ros_setup does in its create_agent_ws.sh.
|
Hey guys, Ryan here from the ArduPilot dev team. The promise of the ROS release process is to preserve ABI on LTS releases. Please be considerate of downstream effects from changes like this, and avoid backporting breaking ABI changes to LTS releases. |
Description
Before #237, the micro-ROS-Agent
SuperBuild.cmakeused to refer to the Micro-XRCE-DDS-Agent asxrceagent, which is inconsistent with the name exported by that package (microxrcedds_agent). In #237, the name and dependencies were updated, but not correctly (in line 24 the old name was kept), which caused some issues and was reverted on #239. The current approach works well for Vulcanexus, but can cause problems depending on the workspace configuration or build order.This PR approaches this issue and tries to generate a consistent behaviour for building the package regardless of where the Micro-XRCE-DDS-Agent is coming from.
SuperBuild.cmakeclones/builds itDEPENDS ${_deps}(non-empty) at the end ofSuperBuild.cmakepackage.xmlMain changes
xrceagentare renamed asmicroxrcedds_agentpackage.xmlnow depends onmicroxrcedds_agentas wellmicroxrcedds_agentis not found, it is added as a dependency to the micro-ROS-Agent external project inSuperBuild.cmakemicroxrcedds_agent 3.0.2or higher is needed, since that version starts exporting an EXACT dependency onspdlog 1.9.2, which ensures that the micro-ROS-Agent build doesn't choose a different version from somewhere else