You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Avoid Internet version checks when displaying local radio information - #996
The local --info command currently contacts PyPI after printing radio information. Off-grid users must wait for the request to fail before the command returns.
Remove that lookup from --info. Radio and node information still print and the connection still closes normally. The existing version check in --support remains available.
Added serial and TCP CLI regressions that assert no HTTP request occurs while both information outputs and connection cleanup still run. Both tests fail on the baseline and pass with this change.
Full default pytest run with optional dependencies installed: 487 passed, 90 deselected (Python 3.12).
Whole-project mypy: success across 84 source files.
Pylint on meshtastic and examples, excluding generated protobuf files as in CI: 10.00/10.
Independent adversarial review and diff check passed.
No physical-radio test was performed. Hosted CI and the Python-version matrix still await maintainer workflow approval.
The contributor agreement check is satisfied. The earlier local type-check errors were resolved by installing missing optional dependencies and matching the relevant locked dependency versions; no additional source changes were needed.
Summary by CodeRabbit
Bug Fixes
The --info command no longer checks for newer versions online or displays upgrade notices.
Local node information can now be viewed without Internet access, including when connected over serial or TCP.
Radio and node details continue to display correctly, with connections closing cleanly and no unexpected error output.
Tests
Added coverage for offline --info usage across serial and TCP connections.
Reviewing files that changed from the base of the PR and between 0a18357 and 8d09c7d.
📒 Files selected for processing: 2
meshtastic/__main__.py
meshtastic/tests/test_main.py
💤 Files with no reviewable changes: 1
meshtastic/main.py
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
The local --info path no longer checks PyPI for a newer Meshtastic version or prints an upgrade notice. A parameterized test covers serial and TCP connections and verifies local information output, no HTTP request, and interface cleanup.
Changes: Local info behavior
Layer / File(s)
Summary
Remove the version check and validate local info meshtastic/__main__.py, meshtastic/tests/test_main.py
The local --info path no longer checks for a newer version. Tests cover serial and TCP connections, confirm no HTTP request is made, and verify information output and interface cleanup.
The change removes the Internet lookup from local --info while retaining information output and connection cleanup in the described test coverage. No issue requiring resolution before merge is identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: removing Internet version checks from local radio information display.
Linked Issues check
Issue #826 requires --info to avoid the PyPI/Internet version lookup while preserving local radio and node information. The supplied PR summary states that the lookup and upgrade notice were removed…
Out of Scope Changes check
The reported changes are limited to removing the version lookup from the --info path and adding focused serial and TCP regression coverage. The tests directly support issue #826 by checking the HTTP…
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Full details: Linked Issues check
Explanation
Issue #826 requires --info to avoid the PyPI/Internet version lookup while preserving local radio and node information. The supplied PR summary states that the lookup and upgrade notice were removed from meshtastic/__main__.py. The added parameterized regression in meshtastic/tests/test_main.py covers serial and TCP paths, asserts no HTTP request, checks both information outputs, and checks connection cleanup. The existing --support version check remains available as required by the PR scope.
Full details: Out of Scope Changes check
Explanation
The reported changes are limited to removing the version lookup from the --info path and adding focused serial and TCP regression coverage. The tests directly support issue #826 by checking the HTTP request, information output, and connection cleanup behavior. No unrelated source or test changes are identified in the supplied evidence.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local --info command currently contacts PyPI after printing radio information. Off-grid users must wait for the request to fail before the command returns.
Remove that lookup from --info. Radio and node information still print and the connection still closes normally. The existing version check in --support remains available.
Fixes #826.
Validation:
The contributor agreement check is satisfied. The earlier local type-check errors were resolved by installing missing optional dependencies and matching the relevant locked dependency versions; no additional source changes were needed.
Summary by CodeRabbit
Bug Fixes
--infocommand no longer checks for newer versions online or displays upgrade notices.Tests
--infousage across serial and TCP connections.