Repository navigation
tests: build blink against platform v0.5.0 - #12
Merged
Merged
Conversation
platform-nordicnrf54 v0.5.0 has the s145 10.0.1 boards, so the s145-10.0.1 branch is no longer needed.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The CI cache key is the hash of tests/blink/platformio.ini, and PlatformIO keeps an installed git platform when the URL has no ref. With the file back at its pre-s145-10.0.1 content, CI restored the old cache and built against platform 0.3.1 (run 40411727019: nrf_soc.h not found). A tag changes the key and fixes the platform version.
caveman99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform-nordicnrf54 v0.5.0 has the s145 10.0.1 boards, so
tests/blinkno longer needs the temporarys145-10.0.1branch. It is pinned to the v0.5.0 tag rather than master: the CI cache key is the hash oftests/blink/platformio.ini, and PlatformIO keeps an installed git platform when the URL has no ref, so going back to plain master restored the pre-#9 cache and built against platform 0.3.1 (run 40411727019). After this, the platform branchs145-10.0.1can be deleted.