Repository navigation
fix(node): put Set display name right after Message in the node menu - #7970
Merged
Merged
Conversation
The menu now opens with the two things you do about that person, per meshtastic/design#171 requirement 4.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node menu now opens with Message then Set display name, the two things you do about that person, per meshtastic/design#171 requirement 4. The Apple app already matches (meshtastic/Meshtastic-Apple#2949).
🐛 Bug Fixes
NodeContextMenumoves Set display name from after Mute to right after Message. Compass and Mesh HUD already sit before Ignore (requirement 5).🧪 Testing Performed
NodeContextMenuOrderTestnow pins the whole order, Message through Remove, with and without Mute. Both cases fail on the old order and pass here.spotlessCheck,detektand:feature:node:allTestspass locally.