Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A registered serial backend can remain physically connected after it is logically disabled.
MultiSerialInterface::isConnected()currently counts that stale connection, although its receive/write/busy paths already exclude disabled interfaces. Require an enabled backend before reporting a connection.Regression coverage checks a disabled Bluetooth backend, another enabled transport remaining connected, re-enabling Bluetooth, and disabling/removing interfaces. Three checks fail on the unmodified
devimplementation and all four pass with this change.Validation:
pio test -e native --filter test_multi_serial_interface: 4/4 passed.pio test -e native -e native_kiss_modem: 62/62 passed.pio run -e muzi_base_uno_superIO_companion_radio_ble: passed.git diff --check: passed.The tests use a backend whose physical connection flag deliberately remains set across
disable(). No protocol or interface-selection behavior changes.