Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the datastore rejects a preferences write,
MyMesh::savePrefs()currently clears the dirty flags anyway. A failed write can therefore leave the in-memory settings marked as saved although they were not persisted. Only clear dirty state afterDataStore::savePrefs()reports success.The method's public signature and successful-save behavior stay unchanged. This does not add a new write format, automatic retry policy or shutdown behavior.
Validation:
savePrefs()method with a failing datastore, checked that dirty state remained set, then allowed a subsequent save and checked that the state cleared.pio run -e muzi_base_uno_superIO_companion_radio_ble: passed.git diff --check: passed.