Repository navigation
Conversation
Member
|
Hey, thanks for the PR. I missed this env when doing the migration. Can you please update the PR to target the |
Author
|
Sure thing! :-) |
Member
|
Thanks. It's still pulling in commits from main branch though, since you made your commits against main, and only changed the target branch on GitHub. You'd need to rebase your local branch against |
The LilyGo_T-Echo-Lite_companion_radio_usb env was missing -D ENABLE_USB_INTERFACE. Without it, ArduinoSerialInterface is never registered with the interface manager, so the USB companion protocol is silently inactive: the USB CDC port enumerates but the device neither receives nor sends companion frames. All other companion_radio_usb builds across the codebase have this flag; this is the only one that did not. Verified: flashing non_shell_companion_radio_usb (which has the flag) restores USB companion connectivity on a T-Echo Lite v1.18.0.
dkuenzel
force-pushed
the
fix/techo-lite-companion-usb-interface
branch
from
October 22, 2026 10:40
81e357c to
4b22c40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LilyGo_T-Echo-Lite_companion_radio_usbenv was missing-D ENABLE_USB_INTERFACE.Without this flag,
ArduinoSerialInterfaceis never registered with theMultiSerialInterfaceinmain.cpp:The result: the USB CDC port enumerates correctly (the device shows up as a serial port), but
checkRecvFrameandwriteFrameare never called for it — the companion protocol is silently inactive. No frame the host sends receives a response.Every other
companion_radio_usbbuild in the codebase carries this flag; the T-Echo Lite was the only exception.Verified against v1.18.0: flashing the device with
non_shell_companion_radio_usb(which already has-D ENABLE_USB_INTERFACE) restores USB companion connectivity immediately. The one-line fix in this PR applies the same correction to the display-capable build.