Skip to content

[WC-3513] Enable react and update to Atlas 4 - #2371

Merged
leonardomendix merged 7 commits into
mainfrom
test/enable-rspack-react
Oct 9, 2026
Merged

leonardomendix merged 7 commits into
mainfrom
test/enable-rspack-react

Conversation

@leonardomendix

@leonardomendix leonardomendix commented Aug 5, 2026 •

Copy link
Copy Markdown
Collaborator

Pull request type

Test related change (New E2E test, test automation, etc.)


Description

This PR updates the used Mendix version to 11.15.0 and, through feature flags, enables React in the test projects and updates Atlas to version 4.

What should be covered while testing?

E2E tests should continue to pass in the automation.

@github-actions

This comment has been minimized.

@gjulivan
gjulivan force-pushed the test/enable-rspack-react branch from 6d84fa8 to 85be6c7 Compare August 19, 2026 13:23
@github-actions

This comment has been minimized.

@leonardomendix
leonardomendix force-pushed the test/enable-rspack-react branch from 85be6c7 to 9cdee50 Compare October 6, 2026 08:31
@leonardomendix leonardomendix changed the title [WC-3513] Enable react and rspack [WC-3513] Enable react and update to Atlas 4 Oct 6, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

AI Code Review

⚠️ Approved with suggestions — low-severity items only, safe to merge


What was reviewed

File Change
automation/run-e2e/docker/mxbuild.Dockerfile Added libgdiplus, libfontconfig1, and LD_PRELOAD env for font rendering
automation/run-e2e/docker/mxbuildRC.Dockerfile Same font library additions as mxbuild.Dockerfile
automation/run-e2e/lib/ci.mjs Flag renamed from --modern-client → --modern-web-client
automation/scripts/update-screenshots-local.mjs Propagates --modern-web-client flag to local mxbuild command
packages/pluggableWidgets/*/package.json (9 packages) e2e script bumped to MX 11.15.0 + MODERN_CLIENT=--modern-web-client; test project branches switched to Atlas 4 variants with atlasCoreVersion/atlasThemeTag
packages/pluggableWidgets/combobox-web/e2e/Combobox.spec.js Scoped locator to .modal-body to avoid ambiguity after Atlas 4 DOM changes
packages/pluggableWidgets/gallery-web/e2e/GallerySelection.spec.js Unchanged logic; diff is whitespace-only around isHidden() calls
Screenshot baselines (*.png across 9 widgets) Updated to match Atlas 4 / React rendering

Skipped (out of scope): pnpm-lock.yaml, dist/


Findings

⚠️ Low — e2edev scripts not updated for datagrid-web and tree-node-web

File: packages/pluggableWidgets/datagrid-web/package.json line 37
File: packages/pluggableWidgets/tree-node-web/package.json (e2edev line)
Note: The e2e scripts were bumped to MX 11.15.0 with MODERN_CLIENT, but the e2edev scripts still reference the old versions (10.24.12.86709 for datagrid, 11.12.0 for tree-node). Developers running pnpm run e2edev locally will use a different Mendix version than CI, which could mask regressions. Consider aligning them or adding a comment explaining the intentional divergence.


⚠️ Low — GallerySelection.spec.js uses .isHidden() without await

File: packages/pluggableWidgets/gallery-web/e2e/GallerySelection.spec.js lines 12, 24
Note: page.locator(".mx-name-feedback1").isHidden() returns a Promise<boolean> that is not awaited and the result is not asserted. This means the visibility check is silently skipped. It was already there before this PR, but since the file was touched the PR is a good opportunity to fix it. Either:

await expect(page.locator(".mx-name-feedback1")).toBeHidden();

or remove the line if the check is intentionally passive.


Positives

  • Flag rename from --modern-client → --modern-web-client is applied consistently across both the Dockerfile ENV LD_PRELOAD path and the compose environment builder in ci.mjs, avoiding a partial migration.
  • Font library dependencies (libgdiplus, libfontconfig1) added to both mxbuild.Dockerfile and mxbuildRC.Dockerfile symmetrically — no divergence between stable and RC build images.
  • atlasCoreVersion and atlasThemeTag are now explicit in every updated package.json, making the Atlas version used for E2E tests auditable at a glance.
  • Combobox locator scoped to .modal-body is a targeted fix that avoids over-specifying the selector.

@leonardomendix
leonardomendix merged commit a34c81f into main Oct 9, 2026
20 of 21 checks passed
@leonardomendix
leonardomendix deleted the test/enable-rspack-react branch October 9, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants