You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WC-3513] Enable react and update to Atlas 4 - #2371
e2e script bumped to MX 11.15.0 + MODERN_CLIENT=--modern-web-client; test project branches switched to Atlas 4 variants with atlasCoreVersion/atlasThemeTag
Unchanged logic; diff is whitespace-only around isHidden() calls
Screenshot baselines (*.png across 9 widgets)
Updated to match Atlas 4 / React rendering
Skipped (out of scope): pnpm-lock.yaml, dist/
Findings
⚠️ Low — e2edev scripts not updated for datagrid-web and tree-node-web
File:packages/pluggableWidgets/datagrid-web/package.json line 37 File:packages/pluggableWidgets/tree-node-web/package.json (e2edev line) Note: The e2e scripts were bumped to MX 11.15.0 with MODERN_CLIENT, but the e2edev scripts still reference the old versions (10.24.12.86709 for datagrid, 11.12.0 for tree-node). Developers running pnpm run e2edev locally will use a different Mendix version than CI, which could mask regressions. Consider aligning them or adding a comment explaining the intentional divergence.
⚠️ Low — GallerySelection.spec.js uses .isHidden() without await
File:packages/pluggableWidgets/gallery-web/e2e/GallerySelection.spec.js lines 12, 24 Note:page.locator(".mx-name-feedback1").isHidden() returns a Promise<boolean> that is not awaited and the result is not asserted. This means the visibility check is silently skipped. It was already there before this PR, but since the file was touched the PR is a good opportunity to fix it. Either:
or remove the line if the check is intentionally passive.
Positives
Flag rename from --modern-client → --modern-web-client is applied consistently across both the Dockerfile ENV LD_PRELOAD path and the compose environment builder in ci.mjs, avoiding a partial migration.
Font library dependencies (libgdiplus, libfontconfig1) added to both mxbuild.Dockerfile and mxbuildRC.Dockerfile symmetrically — no divergence between stable and RC build images.
atlasCoreVersion and atlasThemeTag are now explicit in every updated package.json, making the Atlas version used for E2E tests auditable at a glance.
Combobox locator scoped to .modal-body is a targeted fix that avoids over-specifying the selector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Test related change (New E2E test, test automation, etc.)
Description
This PR updates the used Mendix version to 11.15.0 and, through feature flags, enables React in the test projects and updates Atlas to version 4.
What should be covered while testing?
E2E tests should continue to pass in the automation.