example(afterBurner): keep antiAlias off to preserve the retro look - #1589
Merged
Conversation
`antiAlias: true` was enabled to smooth the low-poly models as they recede, which it does. But the flag drives two other things: the default texture filter goes linear, and the canvas gets `image-rendering: auto` — so under `scale: "auto"` the entire 1024x576 frame is bilinear-filtered on its way to the screen. That trades the example's crisp, blocky presentation for smoother model edges, which is the wrong trade for this scene. `textureFilter` already separates the texture half of that. The presentation half is not separable today, so MSAA'd silhouettes with a hard-edged upscale is not currently expressible — hence off rather than half-configured. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QVjYzf76AEU3wJk766JAQi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
antiAlias: truewas enabled on this example to smooth the low-poly models as they recede. It does that — but the flag drives two other things as well:linear(textureFilter: "auto"followsantiAlias)image-rendering: auto, so underscale: "auto"the whole 1024x576 backing store is bilinear-filtered on its way to the screenThe net effect is that the entire frame is softened to gain smoother model silhouettes, which is the wrong trade for a scene whose look is crisp and blocky.
textureFilteralready separates the texture half. The presentation half is not separable today, so "MSAA'd edges with a hard-edged upscale" is not currently expressible — off is the honest setting rather than a half-configured one.Comment updated to record why, so the next person doesn't re-enable it for the reason it was enabled the first time.