Skip to content

refactor(review): let /review:quality-gate take phase-boundary inputs (worktree, base SHA, quality bar, report-only) #8327

Closed

Description

@kyle-sexton

Parent

Refs #8326 · Source: PLAN Phase 1 (part 1 of 3), topic malleable-design-defaults

Depends on

  • none: on the frontier now

Outcome

An orchestrator can run any /review:quality-gate mode against a phase diff in a separate worktree: it passes a worktree path, a base SHA (the previous phase-boundary commit), the Quality bar: line, and a report-only flag. With a base SHA, no forge lookup runs, so a failed lookup no longer stops a phase-boundary review. The reviewer gets the diff, the concern tag and the quality bar only, in fresh context through review:brief-reviewer, with the plan rationale withheld (the pattern the per-slice brief already uses).

Key interfaces

From the plan's ## Design › Contracts:

Phase-boundary dispatch: architecture → /review:quality-gate architecture; security → /review:quality-gate security; code-design → /review:quality-gate code-design; concurrency → /review:quality-gate slice concurrency (existing mode; reports nothing when the consumer has no concurrency criteria file). The review receives the phase diff, the tag and the Quality bar: line, with rationale withheld.

This item adds the inputs side of that contract to the quality-gate skill for every existing mode; the code-design mode itself is the next item.

Conventions followed: the review plugin's severity tier tests; .claude/rules/skill-bodies-state-current-rules.md.

Done when

  • /review:quality-gate documents worktree path, base SHA, quality bar and report-only inputs for every mode, and allowed-tools covers the worktree-targeted diff form.
  • With a base SHA given, the skill runs no forge lookup.
  • Eval case qg-phase-boundary-worktree (a case.yaml dir under the review plugin's evals/) runs an existing mode from an orchestrator against a separate worktree and base SHA and passes; /evals:plugin-eval with and without the plugin, difference recorded in the PR body.
  • After the commit, bash scripts/check-changed-skills.sh origin/main exits 0 and bash scripts/check-affected.sh --tests exits 0 with no SKIP line.
  • A changelog fragment for the review plugin.

Out of scope

  • The code-design mode and its criteria (next item).
  • Dispatching reviews from the implementation skills (Phase 6 item).

Metadata

Metadata

Assignees

Labels

agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.

Type

Fields

No fields configured for Task.

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions