You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
testing: decide on MSTest IsNotNull(typeof/nameof) and Assert.Equal/NotEqual/Same typeof forms in the cannot-fail audit #7058
A review note from slice B of #6040: the C# cannot-fail audit should flag these forms.
Owner decision (2026-10-11, recorded in the comments):
Flag MSTest Assert.IsNotNull(typeof(X)) and Assert.IsNotNull(nameof(X)).
Flag Assert.Equal / Assert.NotEqual / Assert.Same only when both operands are typeof(...).
A runtime operand such as obj.GetType() stays unflagged.
Pick the rule id following the audit's existing C# rule-id convention.
Done when: the cannot-fail audit flags the forms above, leaves the runtime-operand form unflagged, and has tests for each flagged form and the unflagged form.
Owner decision (2026-10-11): Flag IsNotNull(typeof(...)/nameof(...)), and Equal/NotEqual/Same only when both operands are typeof(...); a runtime operand such as obj.GetType() stays unflagged.
Recorded by the coordinating agent session with the owner's approval. Removing needs-human; implementation is queued and will link its branch here.
The work-resolve-issue lane did not start this issue: it needs a person to make it clearer first.
Why, in the run's own words:
The issue body still asks for an owner decision: flag the MSTest IsNotNull(typeof/nameof) and Assert.Equal/NotEqual/Same typeof forms in the cannot-fail audit (and pick a rule id), or close as not planned. The 2026-10-11 comment from kyle-sexton states a choice (flag IsNotNull(typeof/nameof); flag Equal/NotEqual/Same only when both operands are typeof) but it is not a runner-marked decision (decision: false, not a 'Decision recorded.' comment), so this lane cannot treat it as settling the question. It also names no rule id. Please post a 'Decision recorded.' comment with the choice and the rule id (and say whether the issue stays open), then relabel agent-ready.
Activity
github-actions commentedon Oct 11, 2026
Thanks for the report. Automated triage handed this issue to a maintainer.
Automated triage. A maintainer reviews it.
kyle-sexton commentedon Oct 11, 2026
Owner decision (2026-10-11): Flag IsNotNull(typeof(...)/nameof(...)), and Equal/NotEqual/Same only when both operands are typeof(...); a runtime operand such as obj.GetType() stays unflagged.
Recorded by the coordinating agent session with the owner's approval. Removing
needs-human; implementation is queued and will link its branch here.kyle-sexton commentedon Oct 17, 2026
Admitted in owner wave 1.
melodic-automation-lanes commentedon Oct 17, 2026
The work-resolve-issue lane did not start this issue: it needs a person to make it clearer first.
Why, in the run's own words:
Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/39070350563
To retry, answer the question here, remove
needs-humanand addagent-readyagain.feat(testing): flag typeof/nameof constant oracles in the C# cannot-f…