Skip to content

testing: decide on MSTest IsNotNull(typeof/nameof) and Assert.Equal/NotEqual/Same typeof forms in the cannot-fail audit #7058

Closed

Description

@kyle-sexton

Refs: #6040, #7049

A review note from slice B of #6040: the C# cannot-fail audit should flag these forms.

Owner decision (2026-10-11, recorded in the comments):

  • Flag MSTest Assert.IsNotNull(typeof(X)) and Assert.IsNotNull(nameof(X)).
  • Flag Assert.Equal / Assert.NotEqual / Assert.Same only when both operands are typeof(...).
  • A runtime operand such as obj.GetType() stays unflagged.

Pick the rule id following the audit's existing C# rule-id convention.

Done when: the cannot-fail audit flags the forms above, leaves the runtime-operand form unflagged, and has tests for each flagged form and the unflagged form.

Activity

  1. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 11, 2026
  2. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 11, 2026
  3. github-actions commented on Oct 11, 2026

    @github-actions
    Contributor

    Thanks for the report. Automated triage handed this issue to a maintainer.

    Automated triage. A maintainer reviews it.

  4. kyle-sexton commented on Oct 11, 2026

    @kyle-sexton
    MemberAuthor

    Owner decision (2026-10-11): Flag IsNotNull(typeof(...)/nameof(...)), and Equal/NotEqual/Same only when both operands are typeof(...); a runtime operand such as obj.GetType() stays unflagged.

    Recorded by the coordinating agent session with the owner's approval. Removing needs-human; implementation is queued and will link its branch here.

  5. removed
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Oct 11, 2026
  6. added theissue type on Oct 15, 2026
  7. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    and removed
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 15, 2026
  8. kyle-sexton commented on Oct 17, 2026

    @kyle-sexton
    MemberAuthor

    Admitted in owner wave 1.

  9. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Oct 17, 2026
  10. added
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 17, 2026
  11. melodic-automation-lanes commented on Oct 17, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue lane did not start this issue: it needs a person to make it clearer first.

    Why, in the run's own words:

    The issue body still asks for an owner decision: flag the MSTest IsNotNull(typeof/nameof) and Assert.Equal/NotEqual/Same typeof forms in the cannot-fail audit (and pick a rule id), or close as not planned. The 2026-10-11 comment from kyle-sexton states a choice (flag IsNotNull(typeof/nameof); flag Equal/NotEqual/Same only when both operands are typeof) but it is not a runner-marked decision (decision: false, not a 'Decision recorded.' comment), so this lane cannot treat it as settling the question. It also names no rule id. Please post a 'Decision recorded.' comment with the choice and the rule id (and say whether the issue stays open), then relabel agent-ready.

    Run: https://github.com/melodic-software/claude-code-plugins/actions/runs/39070350563

    To retry, answer the question here, remove needs-human and add agent-ready again.

  12. removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Oct 17, 2026
  13. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.
    on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.

    Type

    Fields

    No fields configured for Task.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions