Repository navigation
fix(testing): test-judge comment-only check and reuse key edge cases #6387
Description
Summary
Close three low-severity edge cases in the test-judge scripts that were deferred from the review of #6305.
Context
- (a) In
judge-lib.shcomment_only, a#line inside a heredoc or a triple-quoted string counts as a comment. - (b) The PASS reuse key collapses whitespace runs, so
a banda bshare a key. - (c) The blob snapshot taken at judge time can race an edit to the file.
Done when
Each of (a), (b) and (c) is either fixed or documented as an accepted limitation, and each fix has a test.
Activity
github-actions commentedon Oct 4, 2026
Thanks for the report. Automated triage handed this issue to a maintainer.
Automated triage. A maintainer reviews it.
kyle-sexton commentedon Oct 11, 2026
Owner decision (2026-10-11): Fix (a): a '#' line inside a heredoc or triple-quoted string counts as code. Document (b) the reuse-key whitespace collapse and (c) the snapshot race. Lands after #7091.
Recorded by the coordinating agent session with the owner's approval. Removing
needs-human; implementation is queued and will link its branch here.kyle-sexton commentedon Oct 18, 2026
This was generated by AI during backlog shaping.
Closing as not planned. PR #7544 (merged 2026-10-16) moved the test judge off hooks and removed the test-judge Stop hook scripts this issue fixes;
plugins/testing/hooks/judge-lib.sh:1-4says no hook runs the library now.The owner approved this close in an attended backlog-shaping session on 2026-10-18 (question: "Close the 9 issues ...?"; answer: "Close all 9 (Recommended)").