You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(testing): read Reqnroll [Then] steps as test starts in the cannot-fail scan #6385
Treat a Reqnroll [Then] step method as a test start in the cannot-fail scan, so step-definition files yield test blocks and [Then] methods with no assertion are reported.
Context
#6342 (merged, testing 0.22.17) made the C# adapters scan *StepDefinitions.cs, but no step attribute is a test start yet, so step files yield zero test blocks. Per the "Operator decision" comment on #6040, only [Then] methods should start a test; [Given] and [When] should not. Refs #6040.
Done when
A [Then] method with no assertion reports rule-zero-assertion.
Thanks for the clear writeup. As I understand it: the cannot-fail scanner now walks *StepDefinitions.cs files (from #6342) but doesn't yet recognize any step attribute as a test start, so those files currently yield zero test blocks. This asks to treat [Then] methods specifically as test starts (per the #6040 operator decision), so a [Then] with no assertion trips rule-zero-assertion, while [Given]/[When] stay non-starts, backed by a corpus pair for both cases.
Scope and acceptance criteria look well-defined, and it references the prior work (#6342, #6040) it builds on. I didn't find any other open issue duplicating this one. No fix or timeline implied here — just confirming the understood scope for maintainers.
Activity
github-actions commentedon Oct 4, 2026
Thanks for the clear writeup. As I understand it: the cannot-fail scanner now walks
*StepDefinitions.csfiles (from #6342) but doesn't yet recognize any step attribute as a test start, so those files currently yield zero test blocks. This asks to treat[Then]methods specifically as test starts (per the #6040 operator decision), so a[Then]with no assertion tripsrule-zero-assertion, while[Given]/[When]stay non-starts, backed by a corpus pair for both cases.Scope and acceptance criteria look well-defined, and it references the prior work (#6342, #6040) it builds on. I didn't find any other open issue duplicating this one. No fix or timeline implied here — just confirming the understood scope for maintainers.
Automated triage. A maintainer reviews it.