Name the conformance section that exists, not one that does not - #13
Merged
Conversation
⚠️ `src/exec.cpp' said "tests/conformance_exec.cpp is where that distinction stops being an argument". That path is in THIS repository and there is no such file: the section is the specification's, at `conformance/src/sections/exec.cpp', and this package reaches it through `run-conformance.sh openkal-macos . full,optional'. A comment naming the place a question is answered is a promise. One pointing at nothing sends a reader to look and leaves them unable to tell whether the check is missing or the reference is --- which is the same defect musl/PATCHES.md was just corrected for, found by reading every file path the new comments name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/exec.cppsaid "tests/conformance_exec.cpp is where that distinction stops being an argument". That path is in this repository and there is no such file — the section is the specification's, atconformance/src/sections/exec.cpp, reached throughrun-conformance.sh openkal-macos . full,optional.musl/PATCHES.mdwas corrected for an hour ago.Found by reading every file path the new comments name and checking each exists, rather than by anything failing.