xlings: the recommended spelling is the namespace on the key, and the advisory teaches it (2026.9.3.2) - #549
Merged
Merged
Conversation
…and the advisory teaches it An entry names a package and then says which version of it, so the namespace belongs to the name: "xim:picolibc-riscv" = "1.8.12". Official packages use that form. The advisory for the superseded deps key suggested the other one. That form is accepted and is what the materialised .xlings.json carries — a key there is an xvm target and the scope qualifies the version — but it is the file's vocabulary, not the author's. A suggestion is copied, so one that teaches the non-recommended form pushes the convention the wrong way. XlingsEntry::authored_line is the recommended spelling and the advisory's only source for it, so the message and the documentation cannot drift. docs/05 states the form and why the other is still accepted; docs/13 and the project-subos example follow. Both languages. Parsing is unchanged, and so is the materialised file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[xlings.workspace]accepts the namespace on either half. This settles which one an author writes, and makes mcpp suggest it.An entry names a package and then says which version of it, so the namespace belongs to the name. Official packages use that form.
Why it matters that the advisory changed
The message for the superseded
[xlings] depskey suggestedpicolibc-riscv = "xim:1.8.12". That form is accepted and is what the materialised.xlings.jsoncarries — a key there is an xvm target and the scope qualifies the version — but that is the file's vocabulary, not the author's. A suggestion is copied, so one that teaches the non-recommended form pushes the convention the wrong way.XlingsEntry::authored_lineis now the recommended spelling and the advisory's only source for it, so the message and the documentation cannot drift.Scope
Parsing is unchanged — both forms produce an identical entry — and so is the materialised file. What changes is one message, and the examples in
docs/05§2.13 (which now states the form and why the other is still accepted),docs/13, andexamples/07-project-subos. Both languages.Verified:
test_manifestasserts the advisory carries the quoted-key form; e2e 331 asserts the same on a real build; 88 and 205 re-run.