Fix prefetch_data_files missing data files nested under data/<subdir>/ - #331
Merged
Conversation
TargetVisitor.prefetch_data_files required a registered file's resolved path to contain the literal substring `data/<name>`, i.e. the file had to sit directly inside a directory named `data/`. McStas nests some data families one level deeper (data/ISIS_tables/, data/Gas_tables/), so e.g. ViewModISIS's Face="TS2.imat" (mcstas-comps/data/ISIS_tables/TS2.imat) was silently skipped even though the registry resolves it correctly. Relax the check to accept `data` as any directory component preceding the filename, not just the immediate parent. Fixes #329.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TargetVisitor.prefetch_data_files required a registered file's resolved path to contain the literal substring
data/<name>, i.e. the file had to sit directly inside a directory nameddata/. McStas nests some data families one level deeper (data/ISIS_tables/, data/Gas_tables/), so e.g. ViewModISIS's Face="TS2.imat" (mcstas-comps/data/ISIS_tables/TS2.imat) was silently skipped even though the registry resolves it correctly.Relax the check to accept
dataas any directory component preceding the filename, not just the immediate parent. Fixes #329.