Skip to content

Add instrument examples of SPODI (FRMII) powder diffractometer - #2608

Draft
kinetik161 wants to merge 3 commits into
mccode-dev:mainfrom
kinetik161:spodi
Draft

Add instrument examples of SPODI (FRMII) powder diffractometer#2608
kinetik161 wants to merge 3 commits into
mccode-dev:mainfrom
kinetik161:spodi

Conversation

@kinetik161

Copy link
Copy Markdown

Free-form text area

Here are two models of the SPODI (FRMII) powder diffractometer:

  • a model using a simplified banana detector: FRMII_SPODI
  • a model representing the real multi-detector geometry: FRMII_SPODI_MULTI.instr

I have not added anything else except for instrument files themselves and documentation README files. @willend , could you please check whether the models in their current form are sufficient?


Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Furter, please describe how / where and for what the tools were used:

Development OS / boundary conditions

Developed and tested on Windows


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes a new instrument file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)
    • I have ensured that basic use of the instrument is OK (e.g. it compiles?)
    • ... and provided reasonable default parameters in that instrument that produce reasonable output
    • ... and maybe even added a %Example: line to describe expected behaviour
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
    • My new instrument is added within the examples hierarchy in a folder in the style of examples/ESS/New_stuff/New_stuff.instr
    • My new instrument has a new, unique filename, not clashing with existing example instruments
    • My new instrument requires a data/input file. If the datafile is specific for my instrument I have left it in the same example folder, but if general use I have placed it in the global data folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant