feat(plan): run the plan-review gate on every plan-mode entry path - #61
Merged
Conversation
The plan-review gate previously lived only in the EnterPlanMode tool-result message, so sessions entered via /plan, Shift-Tab, the --plan flag, default_plan_mode, or a resume never received it. The plan-mode reminders (full/sparse/reentry + inline twins, both engines) now carry the gate with the same wording as the EnterPlanMode message: before ExitPlanMode, run the plan-review skill once when it is available and the plan file lacks a `## Review Findings` section, resolve its findings, and let the skill's close-out call ExitPlanMode (never call it twice). No tool-code or system-prompt changes; EnterPlanMode message unchanged. Tests updated for the new reminder text; token-count inline snapshots regenerated.
…terals The gate step text used \' inside template literals, where apostrophes need no escape; ESLint no-useless-escape flagged three. Plain apostrophes now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No upstream issue — fork-only prompt change (tracked in
fork/PATCHES.md).Problem
The plan-review gate shipped in
0.36.0-MB.1.20lives only in theEnterPlanModetool-result message. Sessions entered via/plan,Shift-Tab, the--planflag,default_plan_mode, or a resume never receive that message, so the gate never fires for them — plans produced on those entry paths go un-reviewed.What changed
Prompt text in both engines (
agent-corev1 andagent-core-v2); no tool-code change, no system-prompt change,EnterPlanModemessage unchanged:EnterPlanModemessage: beforeExitPlanMode, check theplan-reviewskill is in the skill listing, run it once when available and the plan file lacks a## Review Findingssection, resolve every finding, and let the skill's close-out callExitPlanMode(never call it twice).Checklist
gen-changesetsskill, or this PR needs no changeset. (changeset added:.changeset/plan-gate-reminders.md)gen-docsskill, or this PR needs no doc update. (prompt behavior only; docs describe the tool, not the reminders)