xchat: fixed synchronization issues - #116
Merged
Merged
Conversation
highesttt
changed the title
highesttt
force-pushed
the
highest/plat-38383
branch
from
August 14, 2026 00:47
4e243e1 to
6e7247c
Compare
tulir
reviewed
Aug 14, 2026
| if len(resp.Errors) > 0 && resp.Errors[0].Message != "" { | ||
| return CurrentUserProfile{}, fmt.Errorf("GetUsersByIdsForXChat error: %s", resp.Errors[0].Message) | ||
| if len(resp.Errors) > 0 { | ||
| return CurrentUserProfile{}, fmt.Errorf("GetUsersByIdsForXChat returned %d GraphQL errors", len(resp.Errors)) |
Member
There was a problem hiding this comment.
This looks like it's hiding information that was shown before, so maybe don't do that. Also, instead of repeating this for every call separately, it should probably just be handled in makeXChatQueryRequest? Implement the error interface for XChatGraphQLError, then use errors.Join if there are multiple
Fizzadar
approved these changes
Aug 18, 2026
Fizzadar
left a comment
Fizzadar
left a comment
Member
There was a problem hiding this comment.
Had a quick scan and looks ok. Going forward lets split these PRs up a bit and also document the changes in the description please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Checklist
PLAT-38383
PLAT-38382