Repository navigation
Pin core v1.36.4: a file's bytes no longer hold the extension host in a backtracking regex - #50
Merged
Merged
Conversation
… a backtracking regex Core v1.36.4 reads a binary dictionary's interface-dictionary part with a linear scanner instead of a regex that was quadratic on the file's own bytes (core code-scanning alert 2): a binary .sldd of about a kilobyte could hold the extension host for over ten seconds, on open or from the tree view's scan, and one stray quote in a large part made the read throw. Three more patterns that a file reaches, a decimal's digits in complex values and model parameters and the cdata .0 drop, are linear too. A struct type named after an Object.prototype member, such as toString, is classified as one, and a new entry's uuid comes from crypto.getRandomValues in the same shape as before. The lock now resolves data-explorer-core to v1.36.4 (fcf4b46). The lock diff is the spec, the version and the resolved sha, and every lockfile resolution still points at the public registry. Both shipped bundles, dist/extension.js and dist/web/extension.js, lose the old regex. The extension's own version is not bumped here.
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the core pin from
v1.36.3tov1.36.4(fcf4b46). Four lines: the spec inpackage.jsonand in the lock's root entry, and the lock entry'sversionand resolved sha, the same shape as 58ecddb's pin of v1.36.3.What core v1.36.4 brings to the extension:
.slddof about a kilobyte could hold the extension host for over ten seconds, on open or from the tree view's background scan, and one stray quote in a large part made the read throw. Three more patterns a file reaches (a decimal's digits in complex values and model parameters, and the cdata.0drop) are linear too.toStringorconstructoris classified as one (Classify System Composer names by own key, and draw entry uuids from crypto.getRandomValues data-explorer-core#73), and a new entry's uuid comes fromcrypto.getRandomValues, in the same shape as before.Checked in a worktree of this branch:
npm cifrom this lock installs data-explorer-core 1.36.4 and leaves the lock byte-identical (sha256 before and after).npm run verifypasses: typecheck, build, build:web, 3,128 unit tests in 164 files, andcheck:leak(all 646 lockfile resolutions on the public registry or the one allowed core git entry).npm run test:integrationpasses: 168 passing, 1 pending.dist/extension.jsanddist/web/extension.jsbuilt from v1.36.3 (the positive control), and zero times in both built from this branch, which carry the new scanner instead.The extension's own version is not bumped here; users get the fix with the next release built from this pin.