Skip to content

Interface + base class for adaptive function modulus#789

Merged
GiovanniCanali merged 3 commits intomathLab:0.3from
GiovanniCanali:adaptive_function_structure
Apr 21, 2026
Merged

Interface + base class for adaptive function modulus#789
GiovanniCanali merged 3 commits intomathLab:0.3from
GiovanniCanali:adaptive_function_structure

Conversation

@GiovanniCanali
Copy link
Copy Markdown
Collaborator

@GiovanniCanali GiovanniCanali commented Apr 21, 2026 •
edited
Loading

Description

This PR fixes #788

In this PR, the following updates for the adaptive_function module have been introduced:

  • Introduced a unified interface along with a base class structure for adaptive function definition
  • Moved each adaptive function in its own file
  • Improved and expanded documentation for clarity and usability
  • Extended test coverage

The core logic underpinning the entire adaptive_function module has remained unchanged from a user perspective.

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali self-assigned this Apr 21, 2026
@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed 0.3 Related to 0.3 release labels Apr 21, 2026
@GiovanniCanali GiovanniCanali changed the base branch from master to 0.3 April 21, 2026 12:25
@GiovanniCanali GiovanniCanali requested a review from ndem0 April 21, 2026 12:30
@GiovanniCanali GiovanniCanali marked this pull request as ready for review April 21, 2026 12:32
@GiovanniCanali GiovanniCanali requested review from a team and dario-coscia as code owners April 21, 2026 12:32
@dario-coscia
Copy link
Copy Markdown
Collaborator

dario-coscia commented Apr 21, 2026

Thanks for the PR! For me is good to go

@GiovanniCanali GiovanniCanali merged commit 4cf96d1 into mathLab:0.3 Apr 21, 2026
1 of 19 checks passed
@GiovanniCanali GiovanniCanali deleted the adaptive_function_structure branch April 21, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

@ndem0 ndem0 Awaiting requested review from ndem0

Assignees

@GiovanniCanali GiovanniCanali

Labels

0.3 Related to 0.3 release enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New structure for adaptive function

2 participants

@GiovanniCanali @dario-coscia