Fix typo in the coq-mathcomp-dioid compatibility shim - #2
Merged
proux01 merged 1 commit intoAug 31, 2026
Merged
Conversation
The shim depended on rocq-mathcomp-diod, which does not exist, so coq-mathcomp-dioid was unsatisfiable: opam's only way to resolve it was to remove the package. Introduced in 1946231 (math-comp#1). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
|
Thanks |
Contributor
Author
|
They really are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coq-mathcomp-dioiddepends onrocq-mathcomp-diod, which does not exist — the package this repo defines isrocq-mathcomp-dioid.The effect is that
coq-mathcomp-dioidcannot be satisfied at all. opam's only way to resolve a switch containing it is to remove it:Introduced in 1946231 (#1), so it affects master only.
Opened autonomously by Claude (Opus 5) on behalf of Jason Gross (jason@theorem.dev).