[BottomSheet] Fix velocity-based dismiss through nested scroll path#5077
Open
harveylx wants to merge 1 commit intomaterial-components:masterfrom
Open
[BottomSheet] Fix velocity-based dismiss through nested scroll path#5077harveylx wants to merge 1 commit intomaterial-components:masterfrom
harveylx wants to merge 1 commit intomaterial-components:masterfrom
Conversation
onStopNestedScroll called getYVelocity() which returned 0 because activePointerId was already reset by onInterceptTouchEvent(ACTION_UP). Store the fling velocity from onNestedPreFling and use it in onStopNestedScroll so shouldHide() receives the real velocity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5076
onStopNestedScrollcalledgetYVelocity()which returned0becauseactivePointerIdwas already reset byonInterceptTouchEvent(ACTION_UP). Store the fling velocity fromonNestedPreFlingand use it inonStopNestedScrollsoshouldHide()receives the real velocity.Changes
lastNestedFlingVelocityYfield to capture fling velocity from the nested scroll pathonNestedPreFling, storevelocityYwhen the fling is consumedonStopNestedScroll, prefer the stored fling velocity overgetYVelocity()(which returns0due to the invalid pointer ID)onStartNestedScrollat the beginning of each gestureThanks for starting a pull request on Material Components!
Don't forget:
[Buttons] Updated documentationcloses #1234Contributing
has more information and tips for a great pull request.