Skip to content

Solve mutable and immutable task - #3847

Closed
NoDraft-ai wants to merge 3 commits into
mate-academy:masterfrom
NoDraft-ai:correção-tarefa

Hidden character warning

The head ref may contain hidden characters: "corre\u00e7\u00e3o-tarefa"
Closed

NoDraft-ai wants to merge 3 commits into
mate-academy:masterfrom
NoDraft-ai:correção-tarefa

Conversation

@NoDraft-ai

Copy link
Copy Markdown

Implemented the sorted_variables dictionary, separating mutable and immutable variables according to their data types.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This requires changes because the CI is failing due to a linting error, which blocks task completion even though the functionality is correct. Your sorted_variables dictionary is implemented correctly: all eight variables are present and properly classified under the exact keys mutable and immutable. However, flake8 reports W292 at app/main.py:32:2 (no newline at end of file), which stops the pipeline.

Critical issues to fix:

  • app/main.py:32:2 — W292 no newline at end of file. Add exactly one trailing newline at the end of the file to satisfy the linter.

Minor (non-blocking) suggestion:

  • Remove any unnecessary trailing commas for cleaner style, though this does not affect correctness.

Once the final newline is added, the lint step should pass and the rest of the checks can run. Nice job on the correct classification and adherence to the required keys.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@NoDraft-ai NoDraft-ai closed this Sep 15, 2026
@NoDraft-ai
NoDraft-ai deleted the correção-tarefa branch September 15, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants