add task solution - #2048
Conversation
Artroller
commented
Aug 18, 2026
- DEMO LINK
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving this submission because the core functionality is implemented and works as expected: sortList, getEmployees, and the helper getSalary correctly handle sorting and salary parsing, and the functions are invoked properly. However, there is a minor inconsistency in parameter usage: at lines 9–10 and 17, the functions accept employeeList but reference the global list instead. While this doesn’t break functionality, it reduces reusability and can be misleading.
Minor improvement suggestions:
- Use the passed parameter (
employeeList) insidesortListandgetEmployeesrather than the globallist, which will make the functions more modular and testable. - Keep the parameter names consistent and ensure they are actually used, e.g., replace references to
listwithemployeeListwithin the function bodies.
Overall, nice job meeting the requirements and implementing the helpers correctly. Addressing the minor parameter usage will make your code cleaner and more maintainable.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨