Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Preserve named semantic leaves proven by logical-node GetVariableAccessAttributes trees in the canonical live directory without adding per-leaf MMS requests. Existing observed GetNameList points remain authoritative; unknown FCs, arrays, and anonymous placeholders are skipped.
Owner
Author
|
R3 hardening committed at Adds association-scoped
.NET CI run #628 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ARSAS-vs-IEDScout capture audit showed that the current consumer path can amplify initial discovery into ~30.7k confirmed MMS requests (~23.7k GetVariableAccessAttributes and ~6.6k Read) while using only ~1-2 requests in flight, even though the tested association negotiated about 10 outstanding calls. The objective of this PR is to make the engine capable of an IEDScout-like pipelined discovery pattern while preserving ARIEC61850's correctness and receive-pump invariants.
What changed
Smart structural discovery
MmsClientSession.DiscoverSmartAsyncandMmsSmartDiscoveryOptions.(domain, object-class)GetNameList chains with bounded concurrency.maxOutstandingCalling; unknown peers use a conservative fallback cap.moreFollows/continueAfterchain strictly sequential.Association-scoped single-flight
DiscoverSmartSingleFlightAsyncas the consumer-facing orchestration wrapper for repeated smart discovery on one accepted MMS association.Task.WaitAsync; it does not cancel the shared wire operation.Structure-first exact type enrichment
GetVariableAccessAttributesSmartAsync.LN$FC$DOroots first.Safe request pipelining
TpktClient.SendTpktAsyncso concurrent confirmed requests cannot interleave TPKT frame bytes.Documentation
docs/SMART_MMS_DISCOVERY.mdwith invariants, migration example, capture baseline, and acceptance KPIs.Compatibility
The existing
DiscoverAsyncandGetVariableAccessAttributesBatchAsyncAPIs remain unchanged.DiscoverSmartAsyncremains available for callers that deliberately want an uncached generation;DiscoverSmartSingleFlightAsyncis additive for consumers that need association-scoped deduplication.Correctness / safety invariants
Acceptance target
This PR is designed to close the observed scheduling/orchestration gap; it does not claim to be faster than IEDScout until the same IED is re-captured after consumer integration. Acceptance should compare TTFI/TTFT, final LD/LN/FC-point/dataset counts, request count by MMS service, peak outstanding calls, partial-domain status, exact type coverage, and whether any second GetNameList sweep occurs on the same association.
Base:
3afc924c97627fe86adbe784c905e2f35dff0b1a(latestmainat branch creation).