Skip to content

Fix source-backed Legacy SAS RCB export identity - #133

Merged
masarray merged 2 commits into
mainfrom
fix/source-backed-rcb-export-identity
Sep 16, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/source-backed-rcb-export-identity

Conversation

@masarray

Copy link
Copy Markdown
Owner

Purpose

Match IEDScout semantics for source-backed RCB export without changing existing live-model exact-runtime export behavior.

A source SCL can describe one logical ReportControl name="Buffer" with RptEnabled max="2", while the online MMS runtime exposes concrete instances such as Buffer01 and Buffer02. When ARSAS selects one of those runtime slots from a source-backed row, the exported CID/IID must retain the logical source identity and indexing metadata, like IEDScout does, rather than serializing Buffer02 as a separate non-indexed SCL ReportControl.

Change

  • add opt-in PreserveSourceReportControlIdentity to LegacySasSclExportOptions;
  • when enabled, retain the source ReportControl name/indexing/RptEnabled metadata;
  • default remains unchanged: exact runtime export still collapses to one non-indexed concrete instance and strips RptEnabled to prevent double suffixing;
  • add regression coverage for both paths.

No MMS acquisition, report activation, control, runtime discovery, or trusted-SCL reporting behavior is changed.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 3afc924 into main Sep 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant