Fix source-backed Legacy SAS RCB export identity - #133
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Match IEDScout semantics for source-backed RCB export without changing existing live-model exact-runtime export behavior.
A source SCL can describe one logical
ReportControl name="Buffer"withRptEnabled max="2", while the online MMS runtime exposes concrete instances such asBuffer01andBuffer02. When ARSAS selects one of those runtime slots from a source-backed row, the exported CID/IID must retain the logical source identity and indexing metadata, like IEDScout does, rather than serializingBuffer02as a separate non-indexed SCL ReportControl.Change
PreserveSourceReportControlIdentitytoLegacySasSclExportOptions;RptEnabledto prevent double suffixing;No MMS acquisition, report activation, control, runtime discovery, or trusted-SCL reporting behavior is changed.