Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P3 — Sampled Values Analysis
This advances
ROADMAP.mdPriority 2 on top of the merged P0-P2 baseline.Implemented
SvObservedStreamKeyidentity;smpCntcontinuity, wrap, missing-sample, duplicate and out-of-order evidence;smpSynchobservations;SvSustainedObservationSessionas one parsed-frame intake for the existing observation/SCL-comparison path plus sustained analysis;SvSclBoundMeasurementProjector, reusing the existing SCL payload layout and decoder rather than adding a second decoder;SvEngineeringWindowAnalyzer: bounded per-stream/per-channel one-cycle engineering windows feeding the existing RMS/phasor primitive only from successfully scaled SCL-bound samples;SvSampleCounterTrackerfor engineering-window continuity; gap/duplicate/out-of-order/restart evidence discards partial cycles instead of bridging corrupted windows;Architecture / evidence boundary
The existing SV parser, payload decoder, SCL/profile binding and publisher remain authoritative. P3 consumes
SampledValuesFrameafter decode; it does not add a raw capture parser, guess DataSet order from word positions, guess engineering units, silently invent CT/VT ratios, or choose a nominal 50/60 Hz frequency. Ordinary arrival timestamps and gaps remain observation evidence, not automatic proof of PTP quality or physical-network loss.SvEngineeringWindowAnalyzerconsumes only the fail-closedSvSclBoundMeasurementProjection. Raw-only projected values never enter engineering RMS/phasor state. Sample rate, nominal frequency, and optional counter-wrap evidence are explicit inputs with provenance; partial windows are discarded whenever continuity, channel identity, or timebase evidence changes.Documentation:
docs/P3_SAMPLED_VALUES_ANALYSIS.md.Remaining before P3 completion
SvEngineeringWindowAnalyzer;PR remains Draft until those integration/validation items are complete.